limmlingg / i-m-a-converter Goto Github PK

In the feet and inches test page, the title and highlight of the last measurement of 123'53" shows 123' only.

When I console.log() the regex matches in conversion.js: extractFeetAndInchesNum(str), both 123 and 53 are detected. The conversion is also for 123'53".

This is likely caused by addFeetAndInchesTitles() incorrectly calling setTitle() in conversion.js. Should be an easy fix.

For example: http://btobits.com/fixopaedia/fixdic44/tag_35_MsgType_.html

It reads '0', '1' etc. as feet.

We should add a way to check if the number is enclosed by opening and closing quotation marks and not convert it.

Noticeable on sites like https://www.metric-conversions.org/temperature/fahrenheit-to-celsius.htm.
Can also be observed in the feet and inches test page.

When looking at the modified HTML, you can see that the title takes on a weird value:
title="<strange number carried over from somewhere> <f2ctag style="..........

When I console.log the title in the method, it gives me what I expect i.e. 212°F = 100°C. Maybe something is wrong with my innerHTML.replace()? We might need to explore using a different method to do conversion.js: setTitle().

For example: https://en.wikipedia.org/wiki/Fahrenheit, and a Google search for "fahrenheit".

Based on the console.log output, the extension successfully detects the temperatures and converts them. The issue is very likely because of the HTML between the number and the unit, so innerHTML.replace() doesn't work.

For instance, on Wikipedia, the temperature 32 °F is written as 32 °F in HTML.
On Google, some site descriptions have the number in bold, but not the unit, or vice versa.

This issue will likely require major refactoring.

When a page updates, e.g. the user types in 10 °F into the Google search bar, the unit translator should detect it and convert it too.

An easy way is to call addTemperatureTitles() again when the browser detects that the page changed. However, this will probably cause issues for existing conversions as the <f2c> tag will be applied twice to the same part in the HTML because of the innerHTML.replace() in setTitles().

This issue likely requires some rewriting of setTitles() or an extra step during parsing to check if the temperature already has the <f2c> tag.