limeoats / l2dfiledialog Goto Github PK

ImGui::GetWindowContentRegionWidth doesn't exits anymore on the docking branch

From changelog:

 - 2021/08/23 (1.85) - removed GetWindowContentRegionWidth() function. 
keep inline redirection helper. can use 'GetWindowContentRegionMax().x - GetWindowContentRegionMin().x' 
instead for generally 'GetContentRegionAvail().x' is more useful.

I could not find a way to switch file system volume (at least in Windows) from the UI, say moving from C: to D:
Did I miss something?

Hi!

It seems to me that project doesn't have filepath support, only folder support. Please see this code snippet:

`
if (ImGui::Button("Choose")) {

			if (**type == FileDialogType::SelectFolder**) {
				if (fileDialogCurrentFolder == "") {
					strcpy_s(fileDialogError, "Error: You must select a folder!");
				}
				else {
					strcpy(buffer, (fileDialogCurrentPath + (fileDialogCurrentPath.back() == '\\' ? "" : "\\") + fileDialogCurrentFolder).c_str());
					fileDialogFileSelectIndex = 0;
					fileDialogFolderSelectIndex = 0;
					fileDialogCurrentFile = "";
					fileDialogOpen = false;
				}
			}
		}`

You don't have type FileDialogType::OpenFile. I've made nessessary modifications, if you're willing I would like to share.

i have error " use of undeclared identifier 'strcpy_s' "

First of all, great work with the library! I'm just adding a listing of it to my Awesome Dear Imgui list and noticed that your license file is missing from the repo. I'll list it as Apache License as you've written in the readme.md file but let me know if that has changed.

https://github.com/Limeoats/L2DFileDialog/blob/b8bc0495739db5025aa075a545b78555c2cc2199/L2DFileDialog/src/L2DFileDialog.h#L334C1-L334C127

Shouldn't this line append the current folder instead of the current file?

Suggested edit:
auto path = file_dialog_current_path + (file_dialog_current_path.back() == '\\' ? "" : "\\") + file_dialog_current_folder;

After all, that variable is the one that is checked in the if clause on line 330.

Would be hot if L2DFileDialog.h could be in it's own folder.