lily418 / laravel_vision Goto Github PK

groupPhotos method in app/controllers/ImageController is both extremely hackey and almost certainly doesn't belong in the controller.

There's some duplication in the Blade tempting, also app/views/image_upload.blade.php uses knowledge of the model.

I'm not sure I like the way the API is laid out in routes, especially the way image/identity and other methods conflict with image/{id}.

Should be able to POST an image resource and return a prediction of which user the image belongs to.

Users of the API should be able to identify themselves.

The save_image of the model/Image.php should sensibly name the file and add it along with metadata to the database.

Currently each request to /images/identify will need to re-train the Eigen Face Recogniser. A possible solution may be to pickle the Eigen Face Recogniser.

At the moment there is only one collection of faces, there should be a way to create multiple collections.

Images that are uploaded to be identified stay on the server indefinitely, there's also files created by tempnam without extension which are never used.

Make sure the code is expressive as possible or use comments where I fail.

Also I may have slipped into Ruby conventions at some point, so make sure the code conforms to standards.