licoffe / poe-sniper Goto Github PK

The "Clear Filter" button resets league to "Harbinger Hardcore". I am playing Harbinger Softcore so I have to reset this any time I use the "Clear Filter" button. I think it would make most sense if the "Clear Filter" button leaves the league filter at whatever it was previously set at.

Reproduction steps:
Freeze:

1. Add an empty filter.
2. Start running: The application freezes.

Slowdown:

1. Add a filter with armour >= 1 :
2. Start running: The application becomes extremely laggy, unresponsive, and freezes multiple times.

The cause of the issue might be that the search is too broad and the application cannot handle the volume of items.

I frequently leave this sniper and my whoops on overnight to help verify if I have a good idea of the value of an item. I've noticed that occasionally the sniper will get caught in a loop and get stuck on the same next_change_id. It isn't a significant problem as clicking "stop" then "snipe" resets the next_change_id and it will begin working again, but sometimes I'll be playing and realize that I haven't heard a ding in an hour or so when they usually come every few minutes.

Not sure if this is at all possible, but maybe there is a way to run an error check every once in a while. If the next_change_id hasn't updated in 5 minutes maybe auto reset it?

One time it seems to always occur is on realm resets (I assume the river stops during the reset either bc nobody is posting new items or bc ggg turns it off). Not sure if re-checking every 5 minutes would work for that bc realm resets are usually > 5 mins, but if it kept checking I guess it would eventually work.

Title pretty much says it all. When I click the "wiki" link under a filter, it opens 6 separate tabs in by browser all pointing to the same item page on the wiki. Here is a GIF showing the bug in action:

I have no idea how difficult this would be to code, but if it is not very difficult...

As I said in my last request I frequently leave the sniper on overnight to collect results and calibrate my understanding of the market in the morning. Sometimes I wake up to 100+ results from one item (obviously I miscalculated on that item).

The ability to selectively clear certain items to clean up my results would be useful. Maybe after applying a filter to results I could "Clear all filtered results" instead of clearing all?

Anyways, if its too difficult don't worry, but if its an easy add it would be useful.

Thanks as always.

Hello,
Since the new update, i have an issue in filter mode.
The app get only one time the change id in filter Mode and after stay stuck on the change id.
In under pricemode, the change id is correctly renewed.

Similar to poeapp and poe.trade it would be nice if we could include additional ways to include/exclude results. Currently it is fairly difficult to search for good rares unless you have something very specific in mind.

As an example, I'm looking for two-toned boots with 30% ms and a high life roll. I would like high rolls on res, dex or int but I don't care which. In poe trade I would use the following affixes

And
(30 - 30)% increased movement speed
(90 - 124) to maximum life

Sum (60 - )
Dexterity
Intelligence
Fire Resistance
Cold Resistance
Lightning Resistance

I'm sure you already know how that all works so I won't explain any further for "Not", "Count" and "If", just wanted to make sure I gave at least one good example.

Clicking on an affix entry in the filter section should load the values (affix name, min and max) in the fields for edition. The "Add" button would become "Update".

When closing and reopening the program the filters do not load in alphabetic order. This can be solved by clicking on a filter and clicking "update filter", so it is a minor issue.

Demonstration pic:

Might only happen when the window is small enough, I have yet to encounter this on full screen.

Hey Licoffe,

Very nice app, I typically play poe with about 70 poe.trade windows open (and I really only stop there because it starts to get out of hand). I've been trying to find something exactly like this for a few months now. The UI is also clean and immediately comprehensible, overall the app is phenomenal, thank you. I've had a few questions and QoL suggestions, hopefully you don't mind hearing outside perspectives/requests.

1. I have downloaded both the source and the release. I have been able to launch and run the release successfully but not the source. I tried two ways. First I attempted to follow your directions by opening a terminal (windows start button, "cmd" and cloning the code using the git command. I received an error message that git is not a recognized command. Second I attempted to skip the git portion by downloading the code folder onto my computer, then changing to the directory where I have the code stored"cd C:\Users\Home\Desktop\POE Apps\POE-sniper-master-licoffe". The cd was successful but typing "npm install" resulted in an error message "'npm' is not recognized as an internal command, operable program or batch file."

At this point I am stuck on trying to launch the release. Perhaps "terminal" does not mean command prompt? Maybe I need some tools like a compiler or somethign to be directly running the javascript?

2. Just a question. I see that when I close and re-open the release app my searches are being saved, but I can't figure out where (on the release or the source) the searches are being saved. I don't really have a reason besides curiosity and the fact that I haven't been able to find it for asking this.

3. Do you have any plans to add pseudo mods? Res is probably the most challenging mod to search on without pseudo mods.

4. A global option for clipboard would be nice. I assume that I will pretty much always want it completely on (most of the time) or completely off (running lab).

5. Gem Experience: I know that the api provides gem experience. Being able to search on Gem Experience would be a nice sniping bonus, especially early on in the league.

6. Is there a way for me to modify the whisper message in the release version? I found it in the source but as I mentioned earlier, I haven't been able to launch that yet.

That's all I can think of right now. Thanks for any answer you can provide.

Search for 30% Goldwyrm's not working...

https://youtu.be/MY12p6AQpq8

However, I did have previous results for 28% and 29% Goldwyrms. So I checked the filters file and after parsing it in excel noticed that its formatting was somewhat different. Not sure if that could be the issue.

https://youtu.be/xEyntNN2UNk

Hey Licoffe,

Thanks for continuing to improve the sniper. I'm just wondering how the "Underpriced" option works. Is it looking at the items you have filters set up for and underpricing only those items? Or is it underpricing all items in the league. I assume its closer to the first as the second one seems impractical from a programming perspective.

Under Links you have 3 options

• Fewer than 5 links
• 5 links
• 6 links

Can I request an option for the following?

• Fewer than 6 links

After the first few days of a league I will typically 6l everything. As a result a 5l carries no additional value to me. I would prefer to have the ability to split items up into 6l and everything else. Of course I can do that now (by creating 3 separate filters), but having a fourth option would save on # of filters needed.

The affix "% increased maximum energy shield" is missing.

Thanks,
Gdneye

Hi Licoffe,

I would be interested in the ability to turn off the poe.trade stats (either locally or globally). Generally speaking I have not used that feature and I am wondering if it might slow down the processing of the app (or cause timeouts) when I am attempting to run a large number of filters.

Obviously you know the program better than I do. It is possible that this function is so lightweight that it is adding little to no strain. If that Is the case then I'll trust your judgement and you can ignore this feature request.

Thanks,
Gdneye

I had the "BO Only" option checked in the filter.

When clicking on a listed item the notification of the copied message shows in my corner as expected.
However neither CTRL + V nor middle mouse button pastes the message.
Seems like the text is not claimed at all.

Arch Linux x64
Xorg
Xfwm4 (from xfce4)

Upon clicking the trash icon next to a filter, the following error pops up:

Windows cannot find '#!'. Make sure you typed the name correctly, and then try again.

The console logs "clearing" and shows no errors.

1. Open a new filter.
2. Click on the type selectbox.
3. Type something with the keyboard and press enter.
   Current behavior: The correct type is selected.
   Requested behavior: The scrollist starts from under the type selection box, what you type shows up in the selection box, and the list adapts and only shows matching terms (similar to the affix selection).

as title says notification for 1 filter pops each new update of stash ID's

Hi,
Currently have a issue when i move my poe sniper to my secondary screen. Works great until i restart the tool.

Error :

Json content :

{"sound":"sound2.mp3","volume":0.5,"message":"@<account> Hi, I would like to buy your <item> listed for <price> in <league> (stash tab \"<stashTab>\"; position: left <left>, top <top>)","barter":"@<account> Hi, I would like to buy your <item> in <league> (stash tab \"<stashTab>\"; position: left <left>, top <top>)","RATES_REFRESH_INTERVAL":10000,"POE_TRADE_STATS_INTERVAL":3600000,"CHUNK_RETRY_INTERVAL":1000,"CHUNK_DOWNLOAD_INTERVAL":750,"STREAM_TOP_WAIT_INTERVAL":2000,"SCROLL_BACK_TOP_SPEED":500,"NOTIFICATION_QUEUE_INTERVAL":5000,"writeChunkStats":false,"globalClipboard":false,"leagues":["Standard","Hardcore","Legacy","Hardcore Legacy","2 Week Turmoil (JRE094)","2 Week Turmoil HC (JRE095)"],"defaultLeagueIndex":2,"showStatusBar":false,"windowWidth":1296,"windowHeight":1000,"x":1912,"y":-8,"useBeta":false,"checkUnderpriced":false}}

After investigation : one " } " is duplicated at the end of the json.

This seemed pretty straightforward. I downloaded the newest release (freshly because I had previously attempted to copy my filters.json file over and wanted to make sure I was starting 100% clean). Once I loaded it I started re-entering my filters and ran into a problem when I hit the Goldwyrm's. The only thing I can think of that I might have done was moving too quickly (prior to the video). I've noticed sometimes that if I don't wait after adding a filter for the poe.trade stats to fully load before doing my next thing it often causes issues.

https://youtu.be/jWNW874ThR4

Whenever I try to start poe-sniper.exe, I get this error and it will not open. It was working fine for me on 8/5-8/6, but hasn't worked for the past week or so.

Thanks for the great program.

The remove filter buttons have a couple of minor issues.

1. It seems as if it is not possible to remove the very last filter. There are typically n - 1 red lines (where n is the number of filters). Each red line matches up to a filter except the last one. Clicking the general area where the red line should be results in an error message, "Windows cannot find '#!'. Make sure you typed the name correctly, and then try again."

2. The remove filter buttons do not seem to line up well with my mouse position. It seems as if I have to be unusually high for it to hit the remove filter box and work.

Currently the poe.trade link below a filter opens in a PoE Sniper window instead of an actual browser like the other links. Please correct this as right now you cannot interact with many of the site features within that window.

GIF:

I've started using the app and I'm having a problem every time I try to add a 4th filter. I've tried different filters and it errors each time so I don't think its an issue resulting from the specific filter I'm using.

I've uploaded a video showing the issue to youtube...

https://youtu.be/ws1RjKRDn4o

In the video you can see that my 3rd filter is a Goldwyrm and is added fine, but my 4th filter (an eye of Chayula) appeard to load, but if you look at the affixes for both the goldwyrm and the eye you can see that both of them adopt each other's affixes. Its not in the video but the price for Goldwyrm is also updated to the amount I listed for the eye.

Attempting to edit either filter (eye or Goldwyrm) removes the other filter from the filter list (although the filter list still lists 4 total filters). Deleting the remaining filter will reduce the filter list from 4 filters to 2 filters. All of this suggests to me that the two filters somehow become combined.

Hey I'm assuming you're somewhere in the EU or Africa based on when you typically are logged on, just a head's up...

"Negociate price" should be "Negotiate price"

The following steps reproduced the problem for me:

1. Minimize the filters section.
2. Press 'add filter'.

Expected: The filter count goes up by 1.
Current: The filter count becomes 0.

Expanding the filter list and adding/removing any filter solves the issue.
Additionally, the console logs the following error:

GET file:///C:/static/gen/packed_dark.css?f9a65ed1 net::ERR_FILE_NOT_FOUND (from renderer.js: 1178)

I am unable to add a Min and a Max for this affix.

I set up some filters and ran the app overnight. When I came back this morning the results didn't seem to make sense.

Out of 8 filters only one filter (Lion's Roar) provided any responses. Responses for Lion's Roar came through consistently starting at 00:18:32 until 12:10:52. In that time period there were 25 responses, spaced fairly evenly.

In that same 12 hour time period none of the other 7 filters resulted in a single response and some of those filters were quite broad.

Lastly, if I search poeapp.com I see responses from that time frame that should have showed up.

https://youtu.be/o8UlUgldg1I

This is a long-term goal suggestion.

The current interface plays poorly in various resizing attempts. Floats are not nice to play with when things get complex and there are already a bunch of !important rules. Eventually, I fear this will hinder future feature development as getting new elements to act as requested would become a task taking a moderate amount of time.

Using a grid allows for easy insertion and re-positioning of elements, along with naming, potentially allowing future contributors help with tweaking the css (as of now, things are looking scary, and touching anything may break something else).

Grid support was supposedly added to electron recently. If this suggestion is accepted, I would suggest waiting until the next stable version of electron is released, so that the feature is tested.

Occasionally the app has issues moving to the nextchangeid.

I am unsure what causes the issue.

https://youtu.be/_dPIVLILYCI

After your last update the program seemed to work better, but I started adding filters today. Eventually the program failed while attempting to get the next change id. it's possible that its getting to be too much for the program (hence my other post about potentially removing the poe.trade stats).

https://youtu.be/Mugb9-2IbD0

Thanks,
Gdneye

When I click the item message pops up in the toolbar to indicate that the trade message is copied to the clipboard but it does not do that. Any ideas why this is happening? I love your project but I really can't use it if I can't message anyone...

I would like to trade certain items in only certain currencies. Please add more currencies and the possibility to only look at offers in that currency.

Title pretty much says it all. The "Clear filter" button resets everything except the values in the Min and Max fields of the form. It's a minor annoyance. But an annoyance none the less.

Compiled from source - .exe did not have this problem.
Windows 7 SP1 (x64)
git version 2.12.0.windows.1
npm version 3.10.10

I haven't found a definitive pattern yet, but sometimes I become unable to add new filters. I have noticed that it is more likely to occur after the app has ran for a while.

https://youtu.be/hWipcYQ-U3Q

Hi Licoffe,

I tried out poesniper and so far I'm really loving it, here are some features I would love to see in a future release:

-ability to make filter groups like on poe trade with the and or sum count and so on conditions and maybe some improved logic like "if condition is met use filter group 2, else use filtergroup 3"

-searching for items that are already up for trade (not only live search)

• ability to organize my filters, the list should have an option to have expandable named folders and subfolders and the searches itself should be namable. That way instead of a giant filter name with all the conditions which are partly overlapping I could have a neat overview over what I'm searching

-update function via github

-ability to use the underpriced search in conjunction with filters, so far I can either search for my specified stuff with or without a set price, or I can search in general for underpriced stuff. What I would like would be the ability to set a filter like I do at the moment but instead of setting a buyout set the parameters of the underpriced search, so that I can search for specific Items that areunderpriced compared to the rest of the ones matching my filter.

It appears that the latest update may have created some issues with functions that were previously working.

I've been unable to get the "settings" or "Import filter" buttons to work. Also, previously when I moved the slider from "filters" to "underpriced" it would auto collapse the filters and it no longer does this (this last one may have been intentional).

https://youtu.be/7ddmLi6a_lc

Thanks,
Gdneye