Giter Club home page Giter Club logo

Comments (10)

schlawg avatar schlawg commented on May 18, 2024 1

I think it sounds like a great idea. We could optionally attach state objects to every chat message that can reference a round and ply. And they could link to the board state url. This would also be useful for chats on broadcasts and tournaments.

If we run into clutter, I'd happily trade the "flair" area for this badge.

Tooltip would be cool too, but keep mobile in mind.

from lila.

j4cobgarby avatar j4cobgarby commented on May 18, 2024 1

Similar to #1604, and the no of games daily have only increased since then. So as schlawg mentioned, most probably this wont be merged even if someone implemented it.

That's a fair point, I understand the cost of storing a lot more data, but if you for example implemented the timestamp as just a "special string" prepended to each message (even as simple as {7} for ply number 7, that's only a few extra bytes per message. This surely is fine, in the same way that it would be fine if everyone just used a few extra letters when writing their messages.

Of course this runs into backwards compatibility problems, which isn't trivial to work around.

from lila.

j4cobgarby avatar j4cobgarby commented on May 18, 2024

By the way, the same principle should be applied for the chat messages saying that someone offered a draw, etc.

from lila.

j4cobgarby avatar j4cobgarby commented on May 18, 2024

Yep good point with mobile not seeing tooltips...

I will start having a look into implementing this later today then, I assume I'll have to change both the UI code as well as some websockets code so that the new metadata can be saved in the database.

When you mention that each message could link to the board state url, I guess you mean someone can click the message (or the badge next to the message) and be taken to a new page showing how the game was at that time/show that move in the current game window? That seems like a nice idea.

Thanks for the feedback!

from lila.

schlawg avatar schlawg commented on May 18, 2024

So I was thinking about chats on broadcasts there. But for correspondence, clicking a badge could take you to analysis view at the given ply or just rewind the game view to that point. It doesn't exist yet so who's to say?

from lila.

schlawg avatar schlawg commented on May 18, 2024

Back to reality though - as it becomes more complex, the odds of getting something like this merged become vanishingly small.

from lila.

j4cobgarby avatar j4cobgarby commented on May 18, 2024

Yeah that makes sense, it's hard to know where the tradeoff between code simplicity and nice features lies.
That said, I'm now realising this would also have to support chat messages made on game analysis pages, but that shouldn't be very different anyway.

from lila.

Carbrex avatar Carbrex commented on May 18, 2024

Similar to #1604, and the no of games daily have only increased since then. So as schlawg mentioned, most probably this wont be merged even if someone implemented it.

from lila.

j4cobgarby avatar j4cobgarby commented on May 18, 2024

Something else I'm realising is that moves in games can be annotated with messages. So, these annotations are of course linked to a certain move, so I see no reason that chat messages can't be reimplemented in a similar way.

from lila.

Siderite avatar Siderite commented on May 18, 2024

You could add a clock like icon 🕑 somewhere in the chat. When you click on it you see the "timestamps" or "movestamps", I guess, just like the Developer Tool setting in Chrome. That would solve the issue of mobile, too.

from lila.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.