libsdl-org / ghwikipp Goto Github PK

Preview changes absolute links to links relative to the current page, making it appear as if the contributing page editor has made a mistake, broken the page, and should not submit the edit.

For example, currently when you begin to edit:
https://wiki.libsdl.org/SDL2/CategoryInit
...and preview it without making changes, [SDL_Init] makes a link to...
https://wiki.libsdl.org/SDL2/CategoryInit/SDL_Init
...rather than...
https://wiki.libsdl.org/SDL2/SDL_Init
...as it appears before editing.

Comparing https://wiki.libsdl.org/CategoryVideo via the wayback machine and the new version:

Please add a function call which takes SDL_Color as an argument.

Currently these function calls take 3 components r, g, b.

In the Example seection of the SDL_RenderPresent page (https://wiki.libsdl.org/SDL_RenderPresent)
The example code is
<<Include(SDL_RenderClear, , , from="== Code Examples ==", to="== Remarks ==")>>

Hello !

When I use the function SDL_RenderSetLogicalSize() and the Sclale done by this function in X and Y are differents of 1.0f ( in float), the function SDL_SetWindowGrab(pWindow, SDL_TRUE) does not takes this effect, the mouse is not grabbed in the window. When ( in my same program ) the renderer have no set a logical size ( relative to screen format ), the function SDL_SetWindowGrab(pWindow, SDL_TRUE) works perfectly, the mouse is perfectly grabbed.

I try some things for take the mouse grabbed but I d'ont find solution.

It is a bug from thiss functions ?

Thanks for any help...

Arnaud

Maybe we could have a script that pulls this stuff in? We have to figure out what we want this to look like, if we do it.

I was browsing the SDL2 docs about SDL_RendererInfo and some parts of the Remarks were not rendering correctly (notice the <<Include(...)>> parts). Here's a screenshot displaying the incorrect behavior:

The page doesn't list examples of its usage, yet it is incredibly hard to find useful information in other places. Simply using SDL_SetWindowMinimumSize(window, 800, 600); does not work on an X11 Linux Mint 20.1 Ulyssa.

...plug that in at the appropriate point.

hi,
SDL_GetModState give bad value when the numlock key on numeric pad is on.
It's ok when the num lock is off.
I attach a piece of code below to demonstrate that problem :

#include <SDL2/SDL.h>

#include <stdio.h>


int main(int argc, char **argv){
	
   SDL_Surface *surface = NULL;
   SDL_Renderer *renderer;
   SDL_Event event; 
   SDL_Window * window ;
   uint8_t quit=0;
   
  SDL_Rect rect;
  SDL_Init(SDL_INIT_VIDEO);
 
  window = SDL_CreateWindow("LSHIFT", 100, 100, 640, 480, SDL_WINDOW_SHOWN);
  renderer = SDL_CreateRenderer(window, -1, SDL_RENDERER_ACCELERATED); 
  SDL_SetRenderDrawColor(renderer, 255, 0, 0, 255);
  SDL_RenderClear(renderer);
  SDL_RenderPresent(renderer);
  while (!quit) {
       	SDL_PollEvent(&event); 
	switch(event.type) 
        {			
	    case SDL_QUIT:{
		    break;
	    }
	    case SDL_WINDOWEVENT:{
		    switch (event.window.event)  {
		    case SDL_WINDOWEVENT_CLOSE:  {
			    quit=1;
		    }
		    }//switch event.window.event
		    break;
	    }//switch SDL_WINDOWEVENT 
            case SDL_KEYDOWN: 
	    {
	         if (event.key.keysym.sym==SDLK_KP_PERIOD)
	         {
		    int k = SDL_GetModState();		
		    printf("key %i %i \n" , k & KMOD_LSHIFT , k & KMOD_NUM);
	         }			
	    }	
        }//switch event type
    }//!quit
    SDL_Quit();
 
    return 0;
}//main

the printf result will be : 
0 4096 when left shift is down and num lock on instead of 1 4096
1 0 when num lock is off as expected
Thank for your help

When putting in the search term "SDL_EVENT_WINDOW_PIXEL_SIZE_CHANGED", some results are gotten. When clicking on the "SDL_EventType" search result, you are redirected to https://wiki.libsdl.org/SDL2/SDL_EventType . However, "SDL_EVENT_WINDOW_PIXEL_SIZE_CHANGED" does not occur on that page, only on the SDL3 version.

https://wiki.libsdl.org/Tutorials/TextInput returns an HTTP 400 error code.

New pages created through the web interface, generate commits with a message of "Updated" by default. They should probably say "Added."

Also, at some point ghwikipp started dropping the ?q=search_terms from that link, so that's a separate bug. :(

Originally posted by @icculus in libsdl-org/sdlwiki#233 (comment)

I authorised SDL's Wiki to have user:email scope but get a 503 on the wiki with the following error:

GitHub won't tell us your email address, which we need to make edits to the wiki. Check your settings on GitHub?

This is in spite of the following:

For reference my Github account has one primary email and three secondaries. I don't know if this may be a factor.

So we can do things like

<title>@page@ - @wikiname@</title>

These were a big deal on SDL's wiki, but they need some help over here.

Either a script to generate the pages and then hand-edit them, or extend something, I don't know.

There's no keycode and scancode in the SDL_KEYCODE and SDLSCANCODE section . Please fix it as soon as possible .

...just looking for a README that explains all the complex things that need to get wired up to use this.

...so all pages have some common decorations.

...we need some way to get these into an offline mode; either cook the HTML standalone and have a .zip file, provide PDFs, I don't know.

Some call it "main" or "master" or something else, or maybe want to move over to a different branch for whatever reason.

...right now you can log out of GitHub but ghwikipp thinks you're still logged in and won't double-check with GitHub. This is okay for just existing, but for things that change state--posting an edit, deleting a page, we really need to check again with GitHub before committing to the operation.

Maybe there's some basic indexing tool we can incorporate?

And some other things, but this is a big UI requirement.

Since the cronjob script is overwriting them but producing the same file when there are no category changes, the wiki then thinks that all these files need recooking since the timestamps changed, but that's not actually the case. Write to a temp file and diff before renaming, or whatever, instead.

On the wiki page for SDL_Keycode, this text is present:

I assume this text was meant to be replaced/filled in via an automated script.

There doesn't appear to be any documentation on this page regarding SDL_Texture member variables.

Right now each section has an anchor, like this:

https://wiki.libsdl.org/SDL_OpenAudioDevice#code-examples

...but these aren't apparent in the displayed page. It'd be nice if when mousing over a section, a little link icon appeared that indicated you could link directly to this location.

...that just brings you to the shortlog on GitHub.

The fix in #243 is merged, so I'm going to close this, but I'll open an issue in ghwikipp where it'll refuse to accept an edit if pandoc throws an error.

(this particular error was a legacy from our import from MoinMoin, as far as I'm aware, and the preview view will be blank if such an edit were attempted, but that whole thing could be more robust...both in refusing to accept the edit and in the preview showing a "this edit has an error!" message.)

Originally posted by @icculus in libsdl-org/sdlwiki#229 (comment)

...need to check if the editing user is banned, and refuse to accept edits from them.

The idea:

• When someone makes an untrusted edit, we make a topic branch (edit-$USERNAME-$TIMESTAMP) commit there and push it and generate a pull request for it.
• But if they make further edits (fix a typo, add other things), they have to edit the original text again and generate a second PR.
• We should instead make a single topic branch (edit-$USERNAME-$PAGENAME) if it doesn't already exist, and add more commits to it as they edit futher. As these commits are pushed, they just update the existing PR on GitHub, so you can see the revision history inline, and either rebase (several changes in a row that are unique improvements) or squash it (several typo fixes for the original changes) as appropriate.
• When merged, the topic branch is deleted, so future edits will make a new PR.
• When they edit, we start them from the latest in their topic branch instead of the latest in the wiki, so they can edit incrementally without having to redo all their changes to fix an additional typo.

Hello, the values of SDL_Keycode don't appear on the wiki => https://wiki.libsdl.org/SDL_Keycode.

Have a nice day.

On a few of the pages about Mutexes such as this one: https://wiki.libsdl.org/SDL_UnlockMutex
The code example is not showing. Instead, the following text is shown:
Code Examples
<<Include(SDL_CreateMutex, , , from="## Begin Mutex Example", to="## End Mutex Example")>>

A page like 'SDL1.2Tutorials' will confuse the recooker, probably as it parses out the file extension, so it tries to recook every time, deleting a file named "SDL1.html" which likely confirms the suspicion.

For some reason https://wiki.libsdl.org/CategoryEvents doesn't exist, even though https://github.com/libsdl-org/sdlwiki/blob/main/CategoryEvents.mediawiki does

...the triple-backtick thing that Markdown likes doesn't work with pandoc's mediawiki parser. Figure something out for that.

https://wiki.libsdl.org/SDL_RWops

The "Remarks" links on each of the SDL_RWops functions redirect to the SDL wiki home page, rather than the intrapage links for each function's section.

I would have tried to submit an edit for this myself, but I got a 503 error that said "GitHub didn't tell us everything we need to know about you to use this wiki. Please try again later."