libris / whelk-core Goto Github PK

We need to nail down the intended usage (i.e. "meaning") of collection, changedIn and changedBy in Document & LDDB. Do they represent original datasource and/or an LDP container, or something entirely internal? (Also, can the changed* and dependent logic be removed, if the Voyager two-way sync mechanism is to be removed?)

If they are not internal "scratch" data, they need to be modeled and put into the record description. (And become links to proper (collection) resources. See e.g. id, created and updated the Document class for how record description data is used by the system itself.)

The deleted property has been removed from the Document class. All code handling deletes must have some way of setting and detecting this. The fact of deleted is currently manifested as a non-null timestamp value for the new deleted column in the postgres db (lddb).

I assume the solution is something like:

• re-add isDeleted (when deleted != null), or change checks for deleted to doc.deleted != null
• Ensure that deleted timestamps are properly set when whelk.deleteDocument (or similar) is called