Light

libp2p / pull-mplex Goto Github PK

View Code? Open in Web Editor NEW

4.0 24.0 3.0 105 KB

multiplexer implementing the https://github.com/libp2p/mplex spec with pull-streams

License: MIT License

JavaScript 100.00%

mplex pull-stream libp2p

pull-mplex's Introduction

pull-plex

pull-streams based multiplexer implementing the mplex spec

Lead Maintainer

Jacob Heun.

Install
Usage
API
Contribute
License

Install

> npm install pull-mplex

Usage

See the examples.

API

TBD

Contribute

This module is actively under development. Please check out the issues and submit PRs!

License

MIT © Protocol Labs

pull-mplex's People

Contributors

Stargazers

Watchers

Forkers

dryajov isabella232

pull-mplex's Issues

Max size restriction applied to whole message not just data

For incoming messages the max size restriction is applied to the whole message, not just the data field:

https://github.com/libp2p/pull-mplex/blob/master/src/mplex.js#L84-L93

The spec says that the data field can be up to 1MB so this will be causing false positives for certain message sizes.

missing module

Hi
"pull-abortable" in devDependencied instead of production

Mangled PRs

I had a few issues with PRs being mangled (by github?) in this repo. I've reported the issues with github support, but meanwhile #4 seems to be holding up correctly.

What happened:

I've rebased some commits in the original PR (#1) to make it commitlint compliant
after pushing to the PR, github auto-closed the PR (claiming it was me), and didn't allow me to reopen it
creating a new branch and trying to create a new PR didn't work - github would present me with the old (closed) PR link and wouldn't allow me to create a new PR

How I fixed it:

I had to reclone the repo and manually delete the local and remote branches
after that I had to rebase the new branch with master, which allowed me to create a new PR
however, subsequent attempts to fix commit messages let to the same behavior, which required creating a new branch and PR every time.

I've contacted github support, and left a description of the problem. This has left 3 (#1, #2, #3) mangled PRs behind. Please disregard those. Sorry for the spam everybody.

Add to js-ipfs bundles

This issue is for tracking the release of pull-mplex into js-ipfs, as a replacement for libp2p-mplex.

Initial release of pull-mplex
Add pull-mplex to js-libp2p-switch test suite libp2p/js-libp2p-switch#305
Add pull-mplex to js-libp2p test suite libp2p/js-libp2p#325
Replace libp2p-mplex with pull-mplex in js-ipfs bundles ipfs/js-ipfs#1884
- Run js-ipfs test suites
- Run ipfs/interop tests with pull-mplex branch for js-ipfs ipfs/interop#67

Cannot call write after a stream was destroyed

Currently crashing ipfs daemon:

  libp2p:conn:out:QmRRGVzV successfully dialed QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +235ms
  libp2p:conn:out:QmRRGVzV selecting crypto /secio/1.0.0 to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +1ms
  libp2p:secio 1. propose - start +1m
  libp2p:secio 1. propose - writing proposal +0ms
  libp2p:secio 1. propose - reading proposal <Buffer 0a 10 c6 73 16 1b b7 87 ab 7f f5 a7 ca 3c b6 c4 32 d3 12 ab 02 08 00 12 a6 02 30 82 01 22 30 0d 06 09 2a 86 48 86 f7 0d 01 01 01 05 00 03 82 01 0f 00 ... 330 more bytes> +4ms
  libp2p:secio 1.1 identify +60s
  libp2p:secio 1.1 identify - QmRRGVzVMSss6LjhTFZuU4MA5i52ZWca5vPbKhFaPuu88B - identified remote peer as QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +3ms
  libp2p:secio 1.2 selection +0ms
  libp2p:secio 1. propose - finish +5ms
  libp2p:secio 2. exchange - start +60s
  libp2p:secio 2. exchange - writing exchange +0ms
  libp2p:secio 2. exchange - reading exchange +73ms
  libp2p:secio 2.1. verify +75ms
  libp2p:secio 2.1. verify - signature verified +0ms
  libp2p:secio 2.2. keys +0ms
  libp2p:secio 2.3. mac + cipher +1ms
  libp2p:secio 2. exchange - finish +1ms
  libp2p:secio 3. finish - start +60s
  libp2p:secio 3. finish - finish +3ms
  libp2p:conn:out:QmRRGVzV successfully encrypted connection to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +163ms
  libp2p:conn:out:QmRRGVzV upgrading connection to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +0ms
  libp2p:conn:out:QmRRGVzV selecting /mplex/6.7.0 +72ms
  libp2p:conn:out:QmRRGVzV successfully muxed connection to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +75ms
  libp2p:switch:dial starting next dial to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +547ms
  libp2p:switch:dial starting next dial to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +0ms
  libp2p:switch:dial starting next dial to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +0ms
  libp2p:switch:dial starting next dial to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +0ms
  libp2p:switch:dial starting next dial to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +0ms
  libp2p:switch:dial starting next dial to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +0ms
  libp2p:switch:dial starting next dial to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +0ms
  libp2p:switch:dial starting next dial to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +0ms
  libp2p:switch:dial starting next dial to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +0ms
  libp2p:switch:dial starting next dial to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +0ms
  libp2p:switch:dial starting next dial to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +0ms
  libp2p:switch:dial starting next dial to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +0ms
  libp2p:switch:dial starting next dial to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +0ms
  libp2p:switch:dial starting next dial to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +0ms
  libp2p:switch:dial starting next dial to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +0ms
  libp2p:switch:dial stopping the queue for QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +0ms
  libp2p:switch:dial stopping dial queue to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +0ms
  libp2p:conn:out:QmRRGVzV created new stream to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +1ms
  libp2p:conn:out:QmRRGVzV new stream created via muxer to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +0ms
  libp2p:conn:out:QmRRGVzV new stream created via muxer to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +1ms
  libp2p:conn:out:QmRRGVzV new stream created via muxer to QmZMxNdpMkewiVZLMRxaNxUeZpDUb34pWjZ1kZvsd16Zic +1ms
  libp2p:switch:protocol-muxer registering handler with protocol /libp2p/circuit/relay/0.1.0 +20s
  libp2p-mplex:muxer:error receiver stream errored channel destroyed! +60s
NodeError: Cannot call write after a stream was destroyed
    at doWrite (/Users/alan/.iim/dists/[email protected]/node_modules/readable-stream/lib/_stream_writable.js:405:38)
    at writeOrBuffer (/Users/alan/.iim/dists/[email protected]/node_modules/readable-stream/lib/_stream_writable.js:394:5)
    at ResponseStream.Writable.write (/Users/alan/.iim/dists/[email protected]/node_modules/readable-stream/lib/_stream_writable.js:303:11)
    at BufferPeekStream.ondata (_stream_readable.js:705:22)
    at BufferPeekStream.emit (events.js:193:13)
    at BufferPeekStream.Readable.read (_stream_readable.js:496:10)
    at flow (_stream_readable.js:969:34)
    at emitReadable_ (_stream_readable.js:564:3)
    at onEofChunk (_stream_readable.js:525:7)
    at readableAddChunk (_stream_readable.js:244:5)
/Users/alan/.iim/dists/[email protected]/node_modules/ipfs/src/cli/bin.js:8
  throw err
  ^

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.