Giter Club home page Giter Club logo

sparrow.shiny's People

Contributors

elgohr avatar jonocarroll avatar lianos avatar

Watchers

 avatar  avatar  avatar

sparrow.shiny's Issues

Crash when using SparrowResultContainer with only single-feature sets

Reproducible example which ungracefully errors:

> db_single <- sparrow::GeneSetDb(
+     tibble::tribble(
+         ~collection, ~name,      ~feature_id, ~symbol,
+         "some_coll", "some_name", "some_id",   "some_symbol"
+     )
+ )
> 
> sparrow.shiny::SparrowResultContainer(db_single)
Warning in .local(x, ...) :
  Deactivating 1 gene sets because conformation of GeneSetDb to the target creates gene sets smaller than 2 or greater than Inf

Error in featureIds(geneSetDb(x), i, j, value = value, active.only = TRUE,  : 
  collection (i) must be length 1 character vectors

With at least one set with multiple features, the call completes:

> db_multiple <- sparrow::GeneSetDb(
+   tibble::tribble(
+     ~collection,  ~name,       ~feature_id,   ~symbol,
+     "some_coll",  "_name",      "some_id",   "some_symbol",
+     "other_coll", "other_name", "other_id1", "other_symbol1",
+     "other_coll", "other_name", "other_id2", "other_symbol2"
+   )
+ )
>   
> sparrow.shiny::SparrowResultContainer(db_multiple)
Warning in .local(x, ...) :
  Deactivating 1 gene sets because conformation of GeneSetDb to the target creates gene sets smaller than 2 or greater than Inf

$mg
SparrowResult (max FDR by collection set to 0.20%)
--------------------------------------------------- 
No GSEA methods were run, only geneset level statistics calculated

$methods
character(0)

$choices
   collection      label                    value
1: other_coll other_name other_coll_::_other_name

attr(,"class")
[1] "SparrowResultContainer" "list"  

If the SparrowResultContainer requires 2+ feature sets, then I would expect the first call to return an empty result successfully.

Sorting by name in renderFeatureStatsDataTable is broken

The DT::datatable that is generated by the renderFeatureStatsDataTable module does some rewriting of the text in the name/symbol column to link out to a reference page.

When we sort the table by the symbol column, it sorts by the html in that column, rather than the symbol itself. This causes the rows to ultimately be sorted by the feature_id of the feature because the feature_id is ultimately used in the <a href=".."></a> link that gets embedded in that colum

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.