lgarc15 / movie-max Goto Github PK

When the page is scrolled past the top or bottom of the page, white space is revealed. This should be fixed so that the websites background color is displayed instead.

The carousel on the home page has an "About Movie" button for each movie displayed. However, it does not do anything currently. It should be linked to show the movie for that carousel item.

Right now, if the user type into the search input, and then clicks "Enter" something strange happens. The movie is not search for, rather a "?" query string is added to the end of the url, without any params. A possible solution is to focus the "Search" button when the user types into the search bar.

Currently, sub routes such as /movie/<invalid_movie_id> (i.e /movie/testing) will still render the movie page. However, this should not be the case. Rather, the status for the detailed movie API response should be checked and handled accordingly. One such action could be redirecting back to the home page if the movie id is invalid.

Some components share very similar code, such as the slick wheels used in the home page and movies page. In those cases, the code should be broken up into its separate component, in order to reduce duplication.

During development, many of the larger components were naturally broken up into smaller components. Consequently, some of their stylings are still in their parent component. Those styling should be removed from their parent component stylesheets and placed into a separate stylesheet, in order to be more modular.

Currently, the page loader waits for a predetermined amount of time before showing the page. Rather than waiting for a predetermined amount of time, the loader time should be based on when the component receives all the data it needs. This should be done for transitions as well, since it will make navigation and the website responsiveness much smoother, improving user experience.

The current animation library that is used is React Animated CSS. However, React Transitions seems like it would allow further customisation, such as transitions as components unmount.

After leaving the home page (on the initial website load), the scroll spy animation disappears.