lexxpavlov / lexxpavlovsettingsbundle Goto Github PK

Hi.
I try to get data by "name" which doesn't exist and get error
Error: Call to a member function getValue() on null

Please, return "" if settings don't exist.

Hi.
Settings get by "key" or "slug" will be better than by "name".
I put in "name" short information about settings value.

Hello,

I was trying to upgrade my project to Twig 3 and got following error:

Attempted to load class "Twig_Extension" from the global namespace.
Did you forget a "use" statement?

vendor/lexxpavlov/settingsbundle/Twig/SettingsExtension.php:

    namespace Lexxpavlov\SettingsBundle\Twig;

    use Lexxpavlov\SettingsBundle\Service\Settings;

    class SettingsExtension extends \Twig_Extension
    {
        /** @var Settings */
        private $settings;
        /**

Twig_Extension is deprecated since Twig version 2.7, it is required to use "Twig\Extension\AbstractExtension" instead in Twig 3.

It looks like we have two ways to deal with this situation:

1. Fix Twig version in composer.json to 2.x.
2. Bump Twig to ^3.0 and update SettingsExtension.php (BC break).

What would you suggest @lexxpavlov?

Any chance your bundle can support Symfony 4? Maybe, 2.0 branch.

I found this repository https://github.com/vsavritsky/VsavritskySettingsBundle which is literally a copy of your bundle with some deprecations removed/updated.

Great job, btw!

Hi,

When I try to create a new setting, I have this error:

Method "attr" for object "Symfony\Component\Form\Extension\Core\View\ChoiceView" does not exist in form_div_layout.html.twig at line 82

Hi.
It would be good add support for uploading files.

Hi,

I'm using lexxpavlov/settingsbundle 1.3.1 and egeloen/ckeditor-bundle 5.0.3 and after installing both bundles and tried to create or edit a setting, I get this exception:

The same occurs for all this vars: async, jquery, require_js, auto_inline, inline, input_sync, filebrowsers

So I noticed that there are some missing options here:

https://github.com/lexxpavlov/LexxpavlovSettingsBundle/blob/master/Form/Type/SettingValueType.php#L49

That the ckeditor widget needs here:

https://github.com/egeloen/IvoryCKEditorBundle/blob/master/Resources/views/Form/ckeditor_widget.html.twig

Maybe you should add default value for these vars, what do you think about?

Best,
Matías