Giter Club home page Giter Club logo

--sd-webui-ar-plus's People

Contributors

alemelis avatar lev145 avatar minemo avatar roamindev avatar thelounger avatar yownas avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

--sd-webui-ar-plus's Issues

Repo name

Can i propose that you rename the repo to just sd-webui-ar-plus instead of --sd-webui-ar-plus?

This causes filesystem issues when trying to access the files in a command line.

For example, when trying to move the folder mv --sd-webui-ar-plus, it sates ,mv: illegal option -- - because it thinks the folder name is a passed argument.

The Calculated Dimensions are not ideal

Hello, thank you for this great extension.

I should probably revise this to say "the calculated dimension" in the singular, because it seems to only calculate one dimension based on the other.

Screenshot 2024-03-10 101708

Ideally, though, both dimensions would be calculated simultaneously in the same method that Stable Swarm calculates - see ResToModelFit()

The values that your extension sets right now are not the sizes that the base models and most finetunes are trained on.

In a nutshell:
-The model's 'base res' (ei: 1024) is considered the median value, and the height/width are offset proportionately.
-The values are rounded to the nearest multiple of 64.

I spent a bit of time implementing the identical logic in my discord bot (see **update_size_option() section) for it to calculate all the different sizes for my /image command.

Screenshot 2024-03-10 100718

They are calculated dynamically using the same calculation.
However, all the models in Stable Swarm correctly include their base resolution in the metadata, so their function is always predictable and successful. The majority of models on Civitai do not include the intended base resolution in the metadata.

My script assumes the "base resolution" as determined as the current base (Height + Width /2) - whatever these user settings may be.

This is how I recommend your extension should use as the input value - the sum of whatever the current Width/Height values are divided by 2.

I recommend that you consider implementing this approach, if possible!

Why was "Calc" Disabled?

Calc was arguably the most important feature for me personally, so I could scale up images while retaining their aspect ratio without doing the math myself. I am baffled why it was disabled at all

Suggestion: Option to ommit either row

Hello, I think it should be possible for the user to ommit either one of the rows, by either commenting out all the values or some other extension setting that could be added in the A1111 / Forge UI settings.

Screenshot 2024-03-10 102512

This is related to the other issue I just submitted...

While the ratio calculation method remains as it is, I won't be using those buttons and will only have custom sizes.
For now, I will have this irrelevant icon creating an empty row.

Error messages starting Automatic1111 with AR+

Q:\A1111\extensions--sd-webui-ar-plus\scripts\sd-webui-ar.py:448: GradioDeprecationWarning: The style method is deprecated. Please set these arguments in the constructor instead.
arc_calc_height = gr.Button(value="Calculate Height").style(
Q:\A1111\extensions--sd-webui-ar-plus\scripts\sd-webui-ar.py:448: GradioDeprecationWarning: Use scale in place of full_width in the constructor. scale=1 will make the button expand, whereas 0 will not.
arc_calc_height = gr.Button(value="Calculate Height").style(
Q:\A1111\extensions--sd-webui-ar-plus\scripts\sd-webui-ar.py:456: GradioDeprecationWarning: The style method is deprecated. Please set these arguments in the constructor instead.
arc_calc_width = gr.Button(value="Calculate Width").style(
Q:\A1111\extensions--sd-webui-ar-plus\scripts\sd-webui-ar.py:456: GradioDeprecationWarning: Use scale in place of full_width in the constructor. scale=1 will make the button expand, whereas 0 will not.
arc_calc_width = gr.Button(value="Calculate Width").style(

[BUG]: ValueError: not enough values to unpack (expected 3, got 2)

Out of nowhere, suddenly, the extension throws an error and compromises a frozen A1111 v1.7.0 installation and an up to date v1.9.0. It worked flawlessly so far and I used it daily and in every session I do.
Please take a look on this.

*** Error calling: V:\AI_programms\stable-diffusion-webui\extensions--sd-webui-ar-plus\scripts\sd-webui-ar.py/ui
Traceback (most recent call last):
File "V:\AI_programms\stable-diffusion-webui\modules\scripts.py", line 489, in wrap_call
return func(*args, **kwargs)
File "V:\AI_programms\stable-diffusion-webui\extensions--sd-webui-ar-plus\scripts\sd-webui-ar.py", line 282, in ui
self.read_resolutions()
File "V:\AI_programms\stable-diffusion-webui\extensions--sd-webui-ar-plus\scripts\sd-webui-ar.py", line 228, in read_resolutions
self.res_labels, res, self.res_comments = parse_resolutions_file(
File "V:\AI_programms\stable-diffusion-webui\extensions--sd-webui-ar-plus\scripts\sd-webui-ar.py", line 116, in parse_resolutions_file
label, width, height = line.strip().split(",")
ValueError: not enough values to unpack (expected 3, got 2)


Thanks for your efforts.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.