leusgalvan / fixture Goto Github PK

Please add a QA environment without login.

The menu that pops up when the user clicks on its avatar in the navbar is a little misplaced. It should be moved so it appears below the navbar.

The style sucks, make it better

There should be a way to pick some users (even number) and the app should generate teams automatically.

Currently, if you search using lowercase, it won't match with the tournament name if it's uppercase

For small screens, the navbar should collapse into a burguer icon. Clicking the burguer should open a drawer with the links.

A team currently consists of:

• name: string
• members: array of {userId: string, displayName: String}

The AddTeam component, reachable at /team/add, displays a form with a simple text field for the name and a list to select members (users) by clicking them.

There is currently no label to indicate that you are actually choosing members (although that may seem obvious).

Also, each row should have a checkbox for selecting members.

So the buttons for saving and generating don't end up so at the bottom.

If a user is not logged in and tries to access mainMenu or tournaments or teams they should be redirected to login page.

If a user is logged in and tries to access login they should be redirected to mainMenu.

Pick either useStyles or withStyles pattern and stick to it in all components.

In the teams component, when you filter items (by search text, my teams or whatever) and no matching items are found, display a message like "No items to display" or something.

Now that the user can navigate via the navigation bar, the menu is pointless. Remove and show something else in the homepage.

A team currently consists of:

• name: string
• members: array of {userId: string, displayName: String}

The AddTeam component, reachable at /team/add, displays a form with a simple text field for the name and a list to select members (users) by clicking them.

There are currently no validations whatsoever for that form. Some could be:

• Don't allow empty names
• Don't allow names with more than, say, 64 characters.
• Force to choose at least one member (user).

When the user presses the trash icon a dialog should be shown asking the user to confirm the deletion.

We currently have some collections with an explicit id within the data (e.g: userId in the user collection) which looks redundant since Firestore already provides an id for each document.

We may be able to remove these inner ids and use the ones from firebase by ensuring every fetch method from the firebase class appends it.

Both Tournaments and Teams pages have a floating action button for the add functionality. Replace this with a regular button and place it in a better spot.

Right now we simply show a blank space where the pie chart would be. We should show some message like "No games played" or something like that.

Please fix ASAP.