lestercheung / p4review Goto Github PK

Right now if you typo/move the config and try to run this thing it pretends to read the config (not sure why) but then fails saying there is "no p4config section". It would be better to test for file existence and error out early w/ a clear message.

the perforce repo you host this on is erroring 500 right now (hah)... so I'm filing this here.

I was trying to debug email and couldn't. It kept giving me errors about needing to regenerate config. Eventually I realized it needed to have a default value set for the config parser to allow it to be in the config file.

After hearing https://twitter.com/HelloMelanieC talked about testing at https://2019.pycon-au.org/talks/the-unspeakable-horror-of-discovering-you-didnt-write-tests I have decided to dig this project up from https://swarm.workshop.perforce.com/projects/lester-cheung-p4review and start working on it after almost a decade.

PRs welcome!

there's a comment to that effect. Consider this a yes.