leroy-merlin-br / jquery-creditcard-identify Goto Github PK

The plugin is very thin and easy to implement, however, the documentation is not completed.

Let's improve it.

Hi there!

I don't know what are the regexes leroy uses (i think that the reason to not expose default regexes was to hide them, correct if i am wrong), but i think that leading devs to a valuable list of up to date regexes would be cool. My contribution is a point to shopify's list:

https://github.com/Shopify/active_merchant/blob/4f43b39f920ae151c44e2165b6e8342c29a81b7d/lib/active_merchant/billing/credit_card_methods.rb#L5-L18

It might be also very useful to expose a method to perform validation on the classical Luhn Formula, which is very inexpensive (a closure-optimized JS version here: https://gist.github.com/ShirtlessKirk/2134376).

Great job 👍 😸