Giter Club home page Giter Club logo

danger-lgtm's Introduction

leonhartX's github stats

danger-lgtm's People

Contributors

dependabot[bot] avatar kuroruri avatar leonhartx avatar paveg avatar sleekybadger avatar tattn avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar

Forkers

sleekybadger tattn paveg kr9ly kuroruri af12066 ibanez270dx

danger-lgtm's Issues

LGTM.in is shutting down on 2018-10-01.

There is a sad news.

LGTM.in is shutting down on 2018-10-01. I've been busy with a lot of things, and cannot spend time on this. The source is available on github.com/rahulsom/lgtmin and can be used to spin up a similar service. If you're interested in purchasing the domain and continuing to run this service, let me know, and we can work something out.

please, check this.

site: http://lgtm.in/

Bad argument

I get sporadic errors from danger-lgtm that happens sometimes and goes away after a couple of tries.

[!] Invalid Dangerfile file: bad argument (expected URI object or URI string)
 #  from Dangerfile:31
 #  -------------------------------------------
 #  # Looks Good To Me
 >  lgtm.check_lgtm
 #  -------------------------------------------

My guess would be that the LGTM -service returns a bad url and lgtm crashes? I tried to look at fetch_image_url to check if it would be a good place.

Maybe use this somewhere?

require 'uri'

if url =~ URI::regexp
    # Correct URL
end

Undefined method `empty?' for nil:NilClass

Got this with yesterday update to v1.1.0.

 [!] Invalid `Dangerfile` file: undefined method `empty?' for nil:NilClass. 
  #  from Dangerfile:2
  #  -------------------------------------------
  #  shiphawk_plugin.checkup(files: 'diff')
  >  lgtm.check_lgtm
  #  -------------------------------------------
 	from /usr/local/bundle/gems/danger-lgtm-1.1.0/lib/lgtm/plugin.rb:41:in `check_lgtm'
 	from Dangerfile:2:in `eval_file'
 	from /usr/local/bundle/gems/danger-5.16.1/lib/danger/danger_core/dangerfile.rb:297:in `eval'
 	from /usr/local/bundle/gems/danger-5.16.1/lib/danger/danger_core/dangerfile.rb:297:in `eval_file'
 	from /usr/local/bundle/gems/danger-5.16.1/lib/danger/danger_core/dangerfile.rb:200:in `block in parse'
 	from /usr/local/bundle/gems/danger-5.16.1/lib/danger/danger_core/dangerfile.rb:197:in `instance_eval'
 	from /usr/local/bundle/gems/danger-5.16.1/lib/danger/danger_core/dangerfile.rb:197:in `parse'
 	from /usr/local/bundle/gems/danger-5.16.1/lib/danger/danger_core/dangerfile.rb:273:in `run'
 	from /usr/local/bundle/gems/danger-5.16.1/lib/danger/danger_core/executor.rb:29:in `run'
 	from /usr/local/bundle/gems/danger-5.16.1/lib/danger/commands/runner.rb:72:in `run'
 	from /usr/local/bundle/gems/claide-1.0.3/lib/claide/command.rb:334:in `run'
 	from /usr/local/bundle/gems/danger-5.16.1/bin/danger:5:in `<top (required)>'
 	from /usr/local/bundle/bin/danger:23:in `load'
 	from /usr/local/bundle/bin/danger:23:in `<main>'
 [!] The exception involves the following plugins:
  -  danger-lgtm

Looks like URI.join arguments should be forwarded by slash, otherwise they will be overwritten. I will open PR that fixes this issue.

Sorry, I didn't know about such method behaviour.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.