Giter Club home page Giter Club logo

Comments (8)

LeoNatan avatar LeoNatan commented on May 29, 2024

I will take a look soon. Thanks

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on May 29, 2024

The “jump” in the video is unrelated to my framework, but seems like Apple’s launch screen renderer (from the launch storyboard in the app) is buggy.

I cannot reproduce the main issue. From my testing, safe area insets are correctly set:

Safe area insets: UIEdgeInsets: {59, 0, 34, 0}

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on May 29, 2024

Please provide more information with regards to how you set up your hierarchy. It might be a UIKit issue. But since I cannot reproduce, I can’t know for sure.

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on May 29, 2024

You haven’t been active. Please try with my changes in the latest build, and see if that fixes things. If not, please follow requests above.

from lnpopupcontroller.

fredrikp avatar fredrikp commented on May 29, 2024

I updated from 2.13.7 to 2.14.0 but unfortunately I see the same issue in my app. I will attempt to make a standalone demo project to illustrate the issue, but this may take some time.

In the mean time, the hierarchy in my app is as follows:

UIWindow
- UIViewController
- - UITabBarController, presented with .currentContext style
- - - UINavigationController for each tab
- - - - UIViewController inside navcontroller for each tab 
- - - Custom popupBar

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on May 29, 2024

If you are able to reproduce, please attach it here and we'll reopen the issue. Thanks

from lnpopupcontroller.

fredrikp avatar fredrikp commented on May 29, 2024

While creating a project to reproduce the issue I found out what caused it.

When my app displays the popup bar it is always together with a presentation of another UIViewController that contains a chat application. When this view controller is dismissed, the popup bar becomes visible, displaying chat status and unread message.

I had added a delay of 0.1 seconds before displaying the popup bar in order to avoid it being visible for a short time before being covered again by the presented chat view controller.

I guess that this means that your library's size calculations were performed while a view transition was in effect, which led to sizes that were slightly off. Simply removing the delay in my code made the black bar disappear. For some reason, this issue never occurred before the iPhone 14 Pro Max was released.

So no need to reopen the issue. Thanks for your assistance!

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on May 29, 2024

Hm, this shouldn’t really happen. Even if there is animation, there is a layout pass after, so it should calculate with the right numbers. Could you reproduce it on a demo project?

from lnpopupcontroller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.