Comments (8)
I will take a look soon. Thanks
from lnpopupcontroller.
The “jump” in the video is unrelated to my framework, but seems like Apple’s launch screen renderer (from the launch storyboard in the app) is buggy.
I cannot reproduce the main issue. From my testing, safe area insets are correctly set:
Safe area insets: UIEdgeInsets: {59, 0, 34, 0}
from lnpopupcontroller.
Please provide more information with regards to how you set up your hierarchy. It might be a UIKit issue. But since I cannot reproduce, I can’t know for sure.
from lnpopupcontroller.
You haven’t been active. Please try with my changes in the latest build, and see if that fixes things. If not, please follow requests above.
from lnpopupcontroller.
I updated from 2.13.7 to 2.14.0 but unfortunately I see the same issue in my app. I will attempt to make a standalone demo project to illustrate the issue, but this may take some time.
In the mean time, the hierarchy in my app is as follows:
UIWindow
- UIViewController
- - UITabBarController, presented with .currentContext style
- - - UINavigationController for each tab
- - - - UIViewController inside navcontroller for each tab
- - - Custom popupBar
from lnpopupcontroller.
If you are able to reproduce, please attach it here and we'll reopen the issue. Thanks
from lnpopupcontroller.
While creating a project to reproduce the issue I found out what caused it.
When my app displays the popup bar it is always together with a presentation of another UIViewController that contains a chat application. When this view controller is dismissed, the popup bar becomes visible, displaying chat status and unread message.
I had added a delay of 0.1 seconds before displaying the popup bar in order to avoid it being visible for a short time before being covered again by the presented chat view controller.
I guess that this means that your library's size calculations were performed while a view transition was in effect, which led to sizes that were slightly off. Simply removing the delay in my code made the black bar disappear. For some reason, this issue never occurred before the iPhone 14 Pro Max was released.
So no need to reopen the issue. Thanks for your assistance!
from lnpopupcontroller.
Hm, this shouldn’t really happen. Even if there is animation, there is a layout pass after, so it should calculate with the right numbers. Could you reproduce it on a demo project?
from lnpopupcontroller.
Related Issues (20)
- Safe area insets are not maintained correctly in iOS 16 HOT 13
- UIView+LNPopupSupportPrivate.m - Line 296 - valueForUndefinedKey:]: this class is not key value coding-compliant for the key backgroundTransitionProgress HOT 4
- Use the -beginAppearanceTransition:animated: and -endAppearanceTransition APIs HOT 4
- Hope it's not too complicated HOT 1
- Question
- Incorrect popupPresentationState returned after delegate call HOT 4
- SPM resource management is not working HOT 6
- iOS 14 : [<UITabBar 0x11796b300> valueForUndefinedKey:]: this class is not key value coding-compliant for the key backgroundTransitionProgress. HOT 1
- PopupBar is disappearing after hidesBottomBarWhenPushed HOT 1
- Failing builds on Azure Pipeline with Xcode 14. HOT 3
- Carthage build failed with Xcode 14.3 HOT 7
- Left image in popupItem
- iOS 17: New “Floating" Popup Bar Style HOT 10
- iOS 17: Scroll edge appearance does not animate when presenting/dismissing popup bars
- Example App Crashes on launch HOT 15
- Style question HOT 10
- SwiftUI preview does not compile with missing required module 'LNPopupController_ObjC HOT 13
- Floating background color HOT 7
- Larger text sizes / content categories look bad HOT 32
- Bat layout is broken under certain extreme situations HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lnpopupcontroller.