Giter Club home page Giter Club logo

Comments (15)

iDevelopper avatar iDevelopper commented on June 11, 2024 1

Hello @LeoNatan,

Tested in real device iPhone 14 Pro iOS 17 beta, works fine!

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on June 11, 2024

Hello, someone else reported this, but I couldn’t reproduce. @iDevelopper
What OS/hardware?

Thanks!

from lnpopupcontroller.

gtokman avatar gtokman commented on June 11, 2024

I can run the non pop target fine, but the pop up window example crashes every time. I saw you noted a few things about iOS 17 vs 16. But I don't have the new Xcode installed yet to try it.

Xcode 14.3.1
M1 - Ventura 13.5.1

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on June 11, 2024

Thanks, I’ll look again.

from lnpopupcontroller.

iDevelopper avatar iDevelopper commented on June 11, 2024

I can run the non pop target fine also, but the up & down buttons do nothing.

from lnpopupcontroller.

iDevelopper avatar iDevelopper commented on June 11, 2024

Device iPhone 14 Pro, iOS 17.0 & Simulator, Xcode version 15.0 beta 8 (15A5229m), Mac Ventura 13.4.1 (c).

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on June 11, 2024

I see obj is nil for some reason. For me, it doesn't reproduce ever. I will add a check to make sure this crashing flow doesn't happen.

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on June 11, 2024

So apparently, iPhone 13 mini, iPhone 14 Pro and iPhone 14 Pro Max behave differently internally. 🤦‍♂️

I think I have fixed this in the latest release. Please test and let me know @gtokman @iDevelopper @jiangdi0924

from lnpopupcontroller.

jiangdi0924 avatar jiangdi0924 commented on June 11, 2024

So apparently, iPhone 13 mini, iPhone 14 Pro and iPhone 14 Pro Max behave differently internally. 🤦‍♂️

I think I have fixed this in the latest release. Please test and let me know @gtokman @iDevelopper @jiangdi0924

@LeoNatan i hava test in real device iPhone 14 iOS 17 beta, works fine and is very smooth!!! 🙂

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on June 11, 2024

Great, thank you for confirming. Will close the issue for now; let me know if there are more issues.

from lnpopupcontroller.

iDevelopper avatar iDevelopper commented on June 11, 2024

There is a bug when (TabBarController + Navigation Controller) when push next with hidesBottomBarWhenPushed = true.
If we cancel the back animation (swipe) and come back again, the background view disappears.

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on June 11, 2024

Hi @iDevelopper
Could you please record a video of the problem and upload it? Thanks

from lnpopupcontroller.

iDevelopper avatar iDevelopper commented on June 11, 2024

Yes,

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-09-01.at.18.51.22.mp4

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on June 11, 2024

Thanks!

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on June 11, 2024

@iDevelopper I found the issue and will fix it in the next release. Thanks for reporting!

from lnpopupcontroller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.