Memory leak because of timer? about lnpopupcontroller HOT 3 CLOSED

It can also be fixed by only keeping one single instance of the PopupViewController and not creating a new one each time.

from lnpopupcontroller.

I don't understand the problem here. NSTimer retains the provided target until it finishes or is invalidated and released. It is clearly mentioned in the documentation:

The timer maintains a strong reference to target until it (the timer) is invalidated.

LNPopupController is not responsible for your app's logic and/or memory management. If you choose to use NSTimer, you must be aware of how it works, and prepare accordingly. There are several ways to handle memory management; one you have mentioned, another is to use a weak wrapper object as the target of the timer, and only perform the selector on the wrapped object if it is not nil.

I am closing this issue as it is not related to the framework in any way.

from lnpopupcontroller.

Yes you are right. It is not a problem of the framework itself. However I think it might be nice if the demo projects in this repository would take care of this problem. Maybe people using the demo projects as a template will not run into this problem then.

from lnpopupcontroller.