leonardochaia / dotnet-affected-action Goto Github PK

The examples in the README reference this action using leonardochaia/dotnet-affected@v1, however this doesn't work since there is no v1 tag. Adding a v1 tag should resolve this.

Do you mind releasing the latest changes when you get a chance? Thanks.

Hi, thanks for your work on dotnet-affected and this action :)

We have solution files that are not in de git root directory. When we pass the path to the solution as the solution-path variable, this exception is thrown:

Unhandled exception: LibGit2Sharp.RepositoryNotFoundException: Path '/home/runner/work/<subdirectory>' doesn't point at a valid Git repository or workdir.

To me it seems that when a solution-path variable is used, the --repository-path parameter for the underlying dotnet-affected vall should be set to $GITHUB_WORKSPACE. Is this something you agree on? I could look at the implementation myself but first I'd like your approval.

The example in the README uses nrwl/last-successful-commit-action which is deprecated in favor of nrwl/nx-set-shas. Could it be updated?

Should it be something like this?

      - uses: nrwl/nx-set-shas@v4
        id: set_shas

      - uses: leonardochaia/dotnet-affected-action@v1
        id: dotnet_affected
        with:
          from: ${{ steps.set_shas.outputs.base }}
          to: ${{ steps.set_shas.outputs.head }}

When trying to test out dotnet-affected Im getting the following error: Error: Unable to resolve action leonardochaia/dotnet-affected@v1, unable to find version v1

- name: Setup .NET
   uses: actions/setup-dotnet@v3
   with:
     dotnet-version: |
       3.1.x 
       6.0.x

- uses: leonardochaia/dotnet-affected@v1
  id: dotnet_affected
  with:
    from: ${{ github.head_ref }}
    to: ${{ github.base_ref }}