leonardmh / chess-toolkit-rs Goto Github PK

All of the code in the board::coordinate module is written assuming that the conversions between types are always safe because no type can be constructed in an invalid way. However, that assumption is only true if:

1. The Coordinate types are always constructed through the ::new method.
2. The ::new method of each Coordinate type actually imposes necessary bounds checks to ensure validity.

These ::new methods all need to be updated to implement these checks and I should also investigate using an non-instantiable type in the struct definitions so that they can only be constructed through the ::new method.

The timer system as currently implemented allows for player switching and adding time on switch, but there are other features which need to be covered such as delays after switching player before timer actually starts, and more complex clock settings such as what FIDE uses (where different game segments have different amounts of allowed time).

For example, see some of the options available on this clock or some of the more detailed descriptions of time controls on chess.com.