Comments (4)
I don't think there is any harm in collecting that data, it doesn't harm my use case and may prove useful for others.
I'm not touching opts[:head]
or opts[:tail]
in grep, i don't expect them to be set and have no interest in their value, but who knows what other people might use this feature for.
from slop.
I thought Slop was for gathering data from command line options, not a framework for building CLIs..?
from slop.
@c00lryguy Whilst that's true, each command can of course have its own execution block. There are plenty of times where one might want to omit the execution of this block, specifically depending on if another option is used. I completely agree that Slop should continue to collect data and perhaps solely ignore the block.
EDIT: I should also add that there is no magic happening with this code. The :unless
flag is simply checking if an option is available in the arguments passed to Slop.new
this ensures Slop stays below 500 lines
from slop.
DIff is available here. Closing this issue. Discussion can continue if you have anything to add.
Thanks for the comments
from slop.
Related Issues (20)
- Thor comparison HOT 1
- ArgumentError not raised when Array arg is missing HOT 1
- Maybe support a choice option by default HOT 2
- Setting an option doesn't set it "everywhere" HOT 2
- Support for command in v4 HOT 1
- `help: false` throws off separator position HOT 4
- Attempt to modify frozen string litterals HOT 2
- Practical example HOT 5
- CI: Switch away from TravisCI HOT 6
- Conditional 'required' option HOT 2
- Custom message with Slop::MissingRequiredOption
- Ruby v3.0.0 problem with Slop v4.8.2 HOT 2
- Some bugs. HOT 1
- Enable frozen strings in Slop using the `# frozen_string_literal: true` pragma HOT 1
- No way to pass in a blank array? HOT 7
- [question] is there a way to check that one or more of some set of args exist? HOT 2
- Default value for boolean flags not working when invoking method HOT 1
- Issue / breaking change with boolean flags with 4.10.0 HOT 2
- Confusing that there's a 4.0 branch... HOT 1
- Bool options bug! HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from slop.