Giter Club home page Giter Club logo

Comments (4)

 avatar commented on August 25, 2024

I don't think there is any harm in collecting that data, it doesn't harm my use case and may prove useful for others.
I'm not touching opts[:head] or opts[:tail] in grep, i don't expect them to be set and have no interest in their value, but who knows what other people might use this feature for.

from slop.

RyanScottLewis avatar RyanScottLewis commented on August 25, 2024

I thought Slop was for gathering data from command line options, not a framework for building CLIs..?

from slop.

leejarvis avatar leejarvis commented on August 25, 2024

@c00lryguy Whilst that's true, each command can of course have its own execution block. There are plenty of times where one might want to omit the execution of this block, specifically depending on if another option is used. I completely agree that Slop should continue to collect data and perhaps solely ignore the block.

EDIT: I should also add that there is no magic happening with this code. The :unless flag is simply checking if an option is available in the arguments passed to Slop.new this ensures Slop stays below 500 lines

from slop.

leejarvis avatar leejarvis commented on August 25, 2024

DIff is available here. Closing this issue. Discussion can continue if you have anything to add.

Thanks for the comments

from slop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.