lectem / cpp-boilerplate Goto Github PK

replace target_set_warnings by a new INTERFACE target (generated trough add_warnings_interface ?) that you can link. This will give a better control (can use PUBLIC/PRIVATE/INTERFACE when linking)

So I pulled a fresh git copy and when run cmake, it says
/external/fmt and /external/spdlog does not contain a CMakeLists.txt file.

is that expected?

Add new cmake build types for address/memory/undefined behaviour/thread sanitizers

Hi,
do you maybe have integration with cookiecutter in your plans?

Implies adding a .clang-format configuration

It seems that even if tests fail, the CI will still success, need to investigate.

I'm looking at the file Warnings.cmake. From the syntax of the target_set_warnings() function it defines, it seems to allow you to disable or enable specific warnings, not just ALL or Annoying; yet - I can't see where in the code this is handled. It seems like it isn't.

Am I missing something? Is this intentional?

it is not clear if this project boiler plate is buildable?
if so, how to build it?
Maybe put into readme /FAQ

Hi! I'm quite new to cmake, but I tried to run cmake . after bootstrapping the project. It showed an error from here:

if(CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR) message(FATAL_ERROR "Do not build in-source. Please remove CMakeCache.txt and the CMakeFiles/ directory. Then build out-of-source.") endif()

Is there any installation instructions of how to build?

There seems to be quite a few ways to do coverage, using CTest, by copying targets and adding the coverage flags, using a seperate build directory...
Still need to investigate but https://codecov.io or https://coveralls.io/ will be used.

through travis, will need a secure env var

Hi, great repo! I'm learning a lot.

Would be good if Jenkins was also supported. This is a very popular CI tool.

Dependencies have not been updated for a while, it does not really change anything cmake or CI related but it would be good to use the latest versions of libraries.

I've been following the advice given here:

https://crascit.com/2015/03/28/enabling-cxx11-in-cmake/

Why in particular do you prefer target_compile_features(PRIVATE cxx_std_YY)?

Thanks for the example! I'm doing many of the same things, I haven't worked out how you're doing Doxygen, but I do have integrated tests.