lechu445 / lightxmlwriter Goto Github PK

Would it be possible to add a support for ReadOnlySpans even for .NET Standard? It would basically mean to

• Add System.Memory package
• Modify code, so it also exposes Span API and convert to spans to strings as necessary (either AsString method or copy to array and write array)

Rationale:
.NET Standard is now mostly used by libraries that target .NET Core and .NET Framework (also few other, more obscure platforms, I got a bug for Unity).

From practical standpoint, it is very likely they will multi-target .NET Core in the future and take advantage of cool improvements in API (e.g. double.TryFormat as LightXmlWriter sometimes does). In that case, they will likely want to use Span ecosystem for .NET Core.

If anyone is using this library, they most certainly do care about performance and it is highly likely they already use System.Memory package, though they might support .NET Standard for widest audiance.

In current situation, they would have to do conditional compiling for multi targeting

#if NETSTANDARD
  // use string api because LightXmlWriter only exposes strings API for WriteValue and few others
#else
  // use span api
#endif

By adding the Span API for .NET Standard, it would be possible to work around limitations of .NET Framework for allocations (e.g. values are written through ToString methods, see reference source).