learn-co-students / js-basics-online-shopping-lab-bootcamp-prep-000 Goto Github PK

The link "0, 1" (line 67 of README.md) does not work, and probably isn't intended to be a link.

Based on the raw file, I believe that it is supposed to be viewed as this: [0, 1] (0 inclusive, 1 non-inclusive)
Instead it creates an invalid link due to Markdown being supported.

As a result, when clicked:

• From the Learn.co portal:
  • When logged in, it returns you to your current page with a red error message saying "You do not have access to this lesson"
  • When logged out, it brings you to a 404 error page
• From github:
  • It opens up a 404 error page

The test expects removeFromCart to mutate the cart rather than simply returning an updated cart. The instructions, on the other hand, say "return the updated cart", rather than something to the effect of "update the global cart variable before returning the updated cart".

This can be easily addressed through either 1) updating the instructions to make it clear that removeFromCart(item) should mutate the global cart variable, or 2) the test could be updated to use the result of removeFromCart('watermelon'); rather than a call to getCart().