leaguesandbox / leaguesandbox-default Goto Github PK

Missed from previous merge of Nidalee Q.

Add missing _ngrid and other aimesh files

change the line:

to :

spell.AddProjectileTarget("Parley", target);

This file is broken after last commit, replacing it with old aimesh files works.

C# 6 and above allow you to import static members of a class into the local scope via using static declarations. Using this feature would allow us to not have to type ApiFunctionManager.AddBuffHudVisual() or ApiFunctionManager.AddParticleTarget() everywhere, and would allow us to use AddBuddHudVisual() or AddParticleTarget() directly, which I believe would drastically improve readibility.

Beep, boop, I'm a bot! This issue was created by @Pokémonred200 in #development.

One option is to add them manually, another option is to upgrade the project so visual studio adds them automatically.

when Champion reconnect
you can see your spell are "disabled" and don't have spell points,
kind of big problem if we are playing in the game.

I can't make Particle being visible by team, use "SetVisibleByTeam" and "SetGameObjectVisibility" both can't do the thing(about invisible), should we fix this or I just don't use it?

'Placeable', as an object class, are not present in League whatsoever.
Units like lane minions, jungle camps, pets, are all technically minions and are all spawned through SpawnMinion() in league (taken from BB files).
Current packet to spawn "Placeable" is incorrect and in fact a lot of the packets should be removed or replaced with LeaguePackets as they are more consistent and organized.

Title

Turret positions and level props missing.

add that from MapObjects file, turret positions also should be there in some cases.

Currently we create turrets without model names. The names used for creation are the visual names and so doesn't contain the important info like collision radius and so. _game.ObjectManager.AddObject(new LaneTurret(_game, "Turret_T1_R_03_A", 10097.62f, 808.73f, TeamId.TEAM_BLUE, TurretType.OUTER_TURRET, GetTurretItems(TurretType.OUTER_TURRET)));

Turret_T1_R_03_A is visual name. TT_OrderTurret1 is AI/Server name.

Current packet to spawn "Placeables" is incorrect and should be replaced with LeaguePackets version. In the future many more current packets should be removed or replaced with LeaguePackets as they are more consistent and organized.

Some values which are supposed to be short values, are instead representative of unsigned integer values. Example: https://github.com/LeagueSandbox/LeagueSandbox-Default/blob/indev/Stats/ChaosTurretShrine/ChaosTurretShrine.json#L15

The value here is the MaxValue for UInt16, however when opening the original inibin file in Wooxy, the value is a short of -1.
The ContentSerializer likely does not differentiate properly, and thus assumed it was UInt16.

This is needed to test PR LeagueSandbox/GameServer#790

related to #102
Taric spells
Passive (not yet)
Q 100% works
W (without passive)
E (include Stun and increase damage)
R (without Update function)

and if there's having any bugs, please edit/fix it, or contact me to fix that.

Clarity only restores mana to the allied champion with the lowest percentage of Mana, rather than restoring Mana to all allied champions in range. This should be fixed

Beep, boop, I'm a bot! This issue was created by @Pokémonred200 in #development.

Adding Nidalee Q spell.

Karthus Q, as we know the Nuke damage xD, related to #105

• Features :
  1. After 0.5 sec it will make a small AOE damage to Mouse position.
  2. If there are have enemys, it will deal normal damage, if there's only a enemy, then deal double damage.

• Known Issues :
  1. Ring Particle only show "Green" one, because particles can't set to invisible by team.
     (I open an issue of it)
  2. This is a simple codes, after changed the system of it, it will do nothing(maybe).

Currently implementing a channeled spell/buff requires creating all the event handlers yourself per spell/buff. Creating a channel spelltype that handles cancelling on damage/move/stun would help implementing these types of abilities a lot.

Some champion scripts & buffs are here instead of the scripts.

Basically,
Move https://github.com/LeagueSandbox/LeagueSandbox-Default/tree/indev/Champions
To https://github.com/LeagueSandbox/GameServer/tree/indev/Content/LeagueSandbox-Scripts/Champions

Implement the copy on build action in a similar way to GameServer's copy on build, which is cross platform compatible.

Recall is not being cancelled by damage as it should, this thing will be possible after adding channeling in API.

Beep, boop, I'm a bot! This issue was created by @xDawiss in #general.

related to "Teemo Q fixing-patch #106"
spell.AddProjectile(); changed to >spell.AddProjectileTarget();

Determine if recall is a spell or a buff.

See Title. Currently, TakeDamage takes four arguments (a float, a DamageType enum, a DamageSource enum, and a bool that determines if the damage is a critical hit) that could easily be put into a struct.

Beep, boop, I'm a bot! This issue was created by @Pokémonred200 in #development.

No content

Beep, boop, I'm a bot! This issue was created by @Piorrro33 in #game-server.

Adding Garen's ultimate (Demacian Justice)

Refs #110

Switching scripts to be objects, adding OnActivate and OnDeactivate for passives and having Buff scripts.

Add Ignite, Ghost, Revive, Smite, Clarity and Exhaust

Vayne failt to load the skill ... and btw how can we start URF mode ?