lcastelli / chdb Goto Github PK

From trying version 1.0.3, quick notes:

Bad version:

 $ grep PHP_CHDB_VERSION chdb-1.0.3/*h
 chdb-1.0.3/php_chdb.h:#define PHP_CHDB_VERSION "1.0.1"

Bad archive (bad Archive_Tar used to generate the package)

 $ tar tf chdb-1.0.3.tgz 
 package.xml

Shoud use $PHP_LIBDIR instead of "lib" in config .m4 (could be "lib64"), so --with-libdir will be honoured.

 sed -e 's:/lib:/$PHP_LIBDIR:'  -i config.m4

All are trivial.
Thanks

I couldn't find cdhb in the PHP7 extension catalog. Is a port to PHP7 planned?

Currently, chdb throws "Exception" class object, when it cannot find the memory-mapped file. However, this exception is semantically incorrect in this place which forces us to wrap it in try{ }catch{} just to rewrite it into a different object, if our system relies on the exception types to decide what to do with them.

The valid exception is RuntimeException: http://docs.php.net/manual/en/class.runtimeexception.php

The change does not break the backward compatibility.

I tried to store an array as the value in the chdb. It is not said that I can't, and this is something I needed. Unfortunately, chdb thrown lots of warnings "Array to string conversion" when saving the array with chdb_create(). I think that automatic serialization of compound data types would be very useful feature.

The problem is that chdb would have to remember which values are serialized and which ones are not in order not to unserialize an ordinary string by accident.

If this feature is not going to be added, it should be clearly marked that the array values must be scalar types and chdb_create() should fail immediately when something is going wrong.