lazrius / foundryvtt-module-active-defence Goto Github PK

Currently the chat card for active defence does not support correct display of actors using wildcard images for their token. For example the token image path worlds/game-world/data/tokens/commoners/* will appear as the following when rolled in the active defense card:

The default behavior in foundry for wildcards is to load a random image from the directory. The preferred behavior for active defence here would either be to load the image for the token being rolled, or load the default 'art' image from the character sheet instead of the token image.

When making an active defence roll and adding a situational modifier using the provided dialogue, the roll doesn't take the modifier into account for the total roll. In some cases the modifier is recognized in the roll dialogue, but not actually added to the total! (See attached)

Roll with modifier and result:

Roll with a dice modifier, appears but does not total:

You'll need to make sure the modifier applies for normal rolls, as well as those with advantage and disadvantage.

Currently when rolling for active defence the formula is not displayed in the pop-up dialogue where users can select adv/dis/normal options. The standard behavior in foundry is to display this formula as per the below example:

For active defense in this case, this formula should read something like 1d20 + 15 + @bonus.
It might also be neat in this case to use the AC breakdown you can get from mousing over a character's AC in the sheet, making the formula 1d20 + 13 + 2 + @bonus and providing a bit more information instead. (13 base from Wyvern Scales + Dex Modifier).