layervault / layervaultapi.objc Goto Github PK

Ryan LeFevre: hey MT
Ryan LeFevre: my console is spewing this every time the client tries to sync
9/2/14 1:09:27.989 PM LayerVault[87077]: No date formatter for queue 'NSOperationQueue Main Queue'. Creating.
9/2/14 1:09:27.989 PM LayerVault[87077]: Saving date formatter cache
Ryan LeFevre: hundreds of times
Matt Thomas: RL, do you see this multiple times?
No date formatter cache. Creating new.
Ryan LeFevre: i didn’t see that

Mostly we’ve unit tested a handful of MTLModel objects, but the HTTP clients needs to be tested as well.

folderPath/filePath is confusing. This is never the path on the local filesystem

A couple issues:

• - [LVCHTTPClient uploadLocalFile:toPath:parameters:completion:] assumes the credential is in the keychain. It may not be saved there.
• The keychain will be shared because AFOAuth2Client uses it’s own item name and uniquely identifies everything by base URL (which will always be api.layervault.com)

We only check to see if the token is expired when the user first logs in. Unfortunately, that is the only check. If the app is running past token expiration, requests will return 401. Another consideration is that tokens expire based on server time (not client). It’s conceivable that the token might appear unexpired on the client, but expired when it gets to the server.

Proposed handling of expired tokens:

1. Run request (no pre-flight check).
2. If server returns 401 Unauthorized, check the tokens expiry.
3. If expired, re-authenticate with the refresh token.
4. Re-run the original request.

Persistent properties for equality checking:

• userID
• email
• firstName
• lastName
• admin

Transient properties NOT for equality checking:

• organizations
• projects