layer5io / meshery-smi-conformance-action Goto Github PK

Current Behavior

Currently SMI conformance tests results are not being uploaded to http://layer5.io/landscape

Desired Behavior

Have the be uploaded after each successful run

Implementation

Undefined

Acceptance Tests

Mockups

Contributor Guide

Current Behavior

The project's current issue templates are missing an open invitation link where new contributors can join the community's Figma team and view user interface designs and other UX projects.

Desired Situation

Each template that has a reference to Figma in its resources section should an invite link added.

Implementation

 🎨 Wireframes and [designs for Layer5 site](https://www.figma.com/file/5ZwEkSJwUPitURD59YHMEN/Layer5-Designs) in Figma [(open invite)](https://www.figma.com/team_invite/redeem/qJy1c95qirjgWQODApilR9)

Acceptance Tests
All references to Figma include the "open invite" link.

Contributor Guide

Current Behavior

@s1ntaxe770r has an initial draft action.

Desired Behavior

Ideally, the repo is initialize with that draft (even if incomplete), so that others can review and help move it forward.

This can potentially be used as a template for the mesheryctl perf (SMP) action.

Description

README.md is the first file one should read when starting a new project. Our community launched Discussion forum for help seekers; needs to publish it officially on README.md for convenience.

Screenshots

Current behaviour:

Desired behaviour:

Note:
Need to add only last line for Community Forum

Environment:

• OS: any [e.g. Ubuntu]
• Browser: any [e.g. Chrome, Safari]
• Version: any [e.g. 22]
• Device: any [e.g. laptop, iPhone 8]

Reference:

• Take reference to this pull request

Current Behavior

Users are able to run SMI Conformance test and view the percentage of the tests passed in Meshery.

Desired Behavior

Create a badge that can be used in the README to show the pass percentage of the SMI Conformance test that was most recently done. Something similar to this:

Implementation

This might require more changes around the action but here is what I'm proposing:

1. Use the custom endpoints feature from Shields IO to generate the dynamic badge.
2. Create a JSON endpoint in meshery.io/service-mesh-interface to fetch the details to create the dynamic badge. This assumes that each of the participating service mesh has an official account that updates this data as they make new releases.

Blockers

1. No official accounts for service mesh projects.
2. Schedule of reporting: How quickly are the changes in test results reflected on the SMI Conformance Dashboard?

This issue might require more thought so this is just a draft proposal.

Contributor Guide

Description
The Community section in the README says "Access the Community Drive". There is a new procedure of having this automated based on the individual filling in a community member form

Expected Behavior
Update "Access Community Drive" to "To Access Community Drive, fill Community Member Form"

Screenshots

Environment:

• Meshery Version:
• Kubernetes Version:
• Host OS:
• Browser:

Current Behavior

Users are able to run SMI Conformance tests in their CI/CD pipelines and view the percentage of the tests passed in Meshery.

Desired Behavior

Comment the result of the test in the PR which the test was ran on.

This would require the action to be run on every push. This is solely based on the project requirement and would depend on how the projects actually use the action.

Contributor Guide

Current Behavior

Users have to deploy a service mesh manually using some stupid steps.

Desired Behavior

Stop this stupidity and use meshery's power for deploying the service mesh that user wants. 💪

Implementation

Contributor Guide

Description

The workflow uses an unsecure command which has been deprecated now. This causes the action to fail and no notification is sent.

Expected Behavior

When someone stars the repo the workflow should send a notification to #buzz channel on Layer5.

Screenshots/Logs

Logs from GitHub actions runner:

Error: Unable to process command '::set-env name=STARS::2' successfully.
Error: The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands

@leecalcote should i delete some of these workflows ? my brain wouldn't let me rest if these red checkmarks are here

Originally posted by @s1ntaxe770r in #2 (comment)

Current Behavior

Currently the action works the best only with Minikube clusters running with docker driver and Meshery deployed in docker.

Desired Behavior

We shouldn't restrict users to this and expand support to at least some of the popular platforms supported by Meshery.

Reported by @navendu-pottekkat in #32

Current behavior
Currently, the action deploys all the adapters regardless of the service mesh being used because the $service_mesh_adapter is not being read correctly in

Desired behavior
Only the desired adapter should be added to ~/.meshery/config.yaml while creating the new context so as to deploy only that adapter and prevent bloat.

Further description
There is an error being thrown when the context is being created which I believe is causing the default config file being created.

The issue is with this one line:

mesheryctl system context create new-context --adapters $service_mesh_adapter --platform docker --url http://localhost:9081 --set --yes

And I believe that it may have to do something with passing the service_mesh_adapter variable.

Maybe changing it to --adapters="$service_mesh_adapter" or something like that to make sure that we are not passing any extra arguments there would help.

This line runs fine locally when run as shown below. So the issue I mentioned above may causing this.

Description

The slack.yaml GH workflow needs updated to refer to mesheryctl-smi-conformance-action as the repo to watch.

Current #State:
See the white background between the man and woman in the image below that needs to be updated to a better version in the README file.

Desired State:
This is the desired image.

Replace with the image below.

Contributor Resources

• Meshery documentation site
• Meshery documentation source
• Instructions for contributing to documentation