lawnjelly / godot-lportal Goto Github PK

It looks like the examples haven't been updated for the latest changes in lportal. I get this error:
Invalid call to function 'rooms_set_camera' Expected 2 arguments. I fixed it like this:

• var cam1_id = m_RoomManager.dob_register(cam_first, Vector3.ZERO, 0)
• var cam3_id = m_RoomManager.dob_register(cam_third, Vector3.ZERO, 0)

• m_RoomManager.rooms_set_camera(cam_third)
• m_RoomManager.rooms_set_camera(cam_first)

• m_RoomManager.rooms_set_camera(cam1_id, cam_third)
• m_RoomManager.rooms_set_camera(cam3_id, cam_first)

That seems to work, but the camera is not pointed quite right, so make ZERO is the wrong value.

also make a similar change for calls to dob_register.

Whenever I compile Godot with the lportal module, I get this error:

In this issue I will list some of the features I am intending / hoping to put in. Feel free to add feature requests.

• Open and Closable portals
  Think closable doors. Can be used to cull off entire areas. Careful level design can use this to minimize rendering (if for example, a player can only hold one door open at a time).
• Potentially Visible Set (PVS)
  PVS can be precalculated using the room / portal info. A PVS can store which rooms are visible from each room, or even which static objects. This is useful to determine when to switch off other things than rendering that will affect gameplay - AI, physics, sound etc.
• Secondary PVS
  Secondary PVS is a PVS of rooms, but expanded by one. Often this is useful because it allows a bit of gameplay to be going on outside the main area, but not too much.
• Movable Portals
  This could be quite interesting, but may be a challenge to put in and work with a PVS (the PVS will change according to where the portal is).