laurishebert / mastermind Goto Github PK

Why are we using 4 as a radix in this case? The default sc.nextInt() is good enough.

I played with Challanger mode and I got an ex aequo result even thought I clearly won the game at round 4

Here is my game on Challenger Mode :

choose your game mode
1 -Challenger
2 -Défenseur
3 -Duel
1
Choose the maximum number of rounds
5
Round 1/5
choose four digits between 0 and 9 (included) separated by a space
5 5 5 5
[+, -, +, +]
Round 2/5
choose four digits between 0 and 9 (included) separated by a space
8 2 8 8
[=, -, -, =]
Round 3/5
choose four digits between 0 and 9 (included) separated by a space
8 1 6 8
[=, -, =, =]
Round 4/5
choose four digits between 0 and 9 (included) separated by a space
8 0 6 8
[=, =, =, =]
Ex aequo
try Again ? (Y) (N)

Here is my game on Duel Mode :

choose your game mode
1 -Challenger
2 -Défenseur
3 -Duel
3
Choose the maximum number of rounds
5
choose four digits between 0 and 9 (included) separated by a space
1 2 3 4
[8, 5, 4, 1]
Round 1/5
Human Turn
Choose four digits between 0 and 9 (included) separated by a space
2 7 2 7
[+, -, +, -]
Bot turn
[1, 9, 6, 0]
Say more, less, or equal with these symbols (+ - =)
= - - +
[8, 5, 4, 1]
Round 2/5
Human Turn
Choose four digits between 0 and 9 (included) separated by a space
7 2 7 2
[+, +, -, -]
Bot turn
[1, 4, 2, 5]
Say more, less, or equal with these symbols (+ - =)
= - + -
[8, 5, 4, 1]
Round 3/5
Human Turn
Choose four digits between 0 and 9 (included) separated by a space
8 5 5 0
[=, =, -, +]
Bot turn
[1, 1, 4, 2]
Say more, less, or equal with these symbols (+ - =)
= + - -
A cake is a lie
= + - +
[8, 5, 4, 1]
Round 4/5
Human Turn
Choose four digits between 0 and 9 (included) separated by a space
8 5 4 1
[=, =, =, =]
Bot turn
[1, 2, 3, 3]
Say more, less, or equal with these symbols (+ - =)
= = = +
Ex aequo
try Again ? (Y) (N)

https://docs.oracle.com/javase/7/docs/api/java/lang/String.html#equalsIgnoreCase(java.lang.String)

Package level visibility should never be used as it encourages bad practices.

Instead the visibility should be set to one of those three levels (in order of preference): private, protected or public.

The round variable should be private (not directly accessible/modifiable):

Each verification should increase the number of rounds passed:

If we want the current round# to be obtained from the outside, a getter (accesseur) should be used with the proper level of visibility; but round should be private no matter what.

https://ericreboisson.developpez.com/tutoriels/learningjava1/#LIV
https://openclassrooms.com/fr/courses/26832-apprenez-a-programmer-en-java/21282-creez-votre-premiere-classe#/id/r-21241

During the execution we expect the mode to be set to null as a possibility:

So when we do not have a mode selected we should have the mode set to null rather than trying to get the mode immediately again:

The alternative is to assume that the mode can never be null.