lattyware / manydecks Goto Github PK

Describe the feature

Currently, when searching by language, Many Decks will differentiate between different countries. This means that there is an option to search for English (no country), EN-AU, EN-US and so on. It may be good if searching for English decks would return English decks from all countries by default and the user would have to specify if they only wanted from a certain country, as most of the time the country does not matter provided it is the same language.

Describe the bug

I try to log into my Many Decks account, which is connected to my Google account. The Google Authenticator window shows an error message, shown in screenshot.

(I'm using Firefox, if that helps)

How to reproduce the bug

Happened to me every time I tried to log in with Google. Can still log in with Twitch, but my decks aren't associated with that account.

Expected behaviour

Open Google Authenticator, choose/confirm account, get logged in.

It would be great if there was the possibility to download a deck (even a not mine deck, but a deck I found that I'd like to modify to my preference) as a plain text, as the one I had to paste in the "import" section, like this:
something here _ is a black card
Something here is a white card
In order to fasten the edit process

Feature request for public decks so that users can make and share decks with everyone. A rating and search system would be good as well so that users can sort by most played/liked and search by keywords.

Opening the decks.rereadgames.com website only shows the spinner and nothing else. In the console the website also prints hundreds and hundreds of errors (see below).

I don't know if this is general or just for me, but I have tested it on 2 computers and multiple browsers, with the same error.

Uncaught TypeError: Cannot read property 'elmFs' of undefined
    at Un (many-decks.4400b9570fb1efc115b1.js:1)
    at xn (many-decks.4400b9570fb1efc115b1.js:1)
    at Xn (many-decks.4400b9570fb1efc115b1.js:1)
    at Gn (many-decks.4400b9570fb1efc115b1.js:1)
    at Fn (many-decks.4400b9570fb1efc115b1.js:1)
    at many-decks.4400b9570fb1efc115b1.js:1
    at e (many-decks.4400b9570fb1efc115b1.js:1)

So the docker build for the latest version is failing.

To begin with, this was some small stupid things, but after fixing those, I'm getting failures from the new unique-names-generator package, but only when built and run in the docker environment. I've verified the files are in the docker container, so not sure what is going on.

Describe the feature

being able to download the deck and print it off so you can play at home with friends

1. I cannot sign up nor create any decks. There's no option to create a new deck and when I sign up with Google nothing happens.

How to reproduce the bug

Steps to reproduce the behaviour:

1. Go to main page
2. Click sign up
3. Click sign up with Google

Expected behaviour

I expected to be able to sign up and at that point be able to create a deck

Google have deprecated the existing sign-in system and it will stop working as of March 31, 2023. It will need to be replaced in Many Decks before then.

The replacement is Google Identity Services, but ideally it'd be best to move away from manually having these sign in options and just using some existing combined account system to unify everything and move it into known implementations, ideally with classic username/password support, webauthn support, other providers, etc... which would also solve #1.

It would be good to offer localization of the UI, as done with Massive Decks.

I'll probably leave doing this until someone makes the first (non-binding!) offer to do a localization—no point implementing it if no one cares, so do say if it is a feature you care about.

Screenshot

I tried using Many Decks, but was unable to navigate the page. The only things I can click on are the language, the Sign In button, and I can physically type in the search bar, however the actual search function does not work. Even after going to Sign In, both options to sign in with Google or Twitch do not work. I can click the buttons, but it remains on that page.

When importing, it would make sense for slots to have heuristics applied to do things like capitalise slots at the start of cards, or after end-of-sentence punctuation.

There are official CaH packs that include images rather than just text, it would be nice to offer something similar.

Hosting images has increased cost and load implications which would need to be addressed if that was the route taken.

See Lattyware/massivedecks#151 for the implementation of game support for this, which is clearly heavily tied to the implementation here.

Not sure how else to put it; I've tried both login options but I do not appear to be signed in. Back to back, I can try the options because neither of them log me in. Idk if it's because I've never had ann account on this service prior to the bug? Are returning users still logging in?

1. Click sign in
2. Choose option
3. Select credentials, allow access
4. repeat steps 2-3 ad infinitum

Can't upload screenshots

Describe the bug

The editor of call cards doesn't work—cards can be created and removed, but editing the content doesn't work.
The cursor stays in the initial position and no changes can be made do the card.

How to reproduce the bug

Steps to reproduce the behaviour:

1. Sign in
2. Go to the decks page
3. Create a new call card or edit an existing one
4. Attempt modifying its content

Expected behaviour

The card should be editable

Attachments

Sometimes, a card may contain some less known reference, or the person may just not understand it. A nice feature would be if you could add a tooltip to the card, or some additional info displayed after clicking on some ⓘ info button on the card. Of course, it would be optional to add this extra info to any card, in case the author doesn't want to.

Describe the feature

I looking a way to import csv. It seems manydecks doesnt include import csv feature

Currently the call editor has some usability and responsiveness issues, and doesn't support editing certain things (e.g: #9).

We should automatically split requests like that up on the client side.

For now, if you ruin into this, just try importing in smaller batches and it should work.

Currently while you can sign in with multiple methods, each method will create a different account. It would be nice to offer functionality to allow multiple methods to be tied to a single account.

Under cardcast, you could order a physical copy of your cards printed by one of the online POD houses. Great for taking a deck you'd worked on online and using it for at-home play.

Massive Decks already supports this via an optional index parameter on slots, so if we can produce it, it'll work, e.g:

  calls: [
    [
      ["Steve Ballmer:"],
      [
        "“",
        { "transform": "UpperCase" },
        ", ",
        { "transform": "UpperCase", "index": 0 },
        ", ",
        { "transform": "UpperCase", "index": 0 },
        ".”",
      ],
    ],
  ],
  responses: [
    "developers",
  ]

The question is how to integrate this nicely into the editor experience.

It would make sense to somehow allow decks to be shown as popular or not (liking, rating, something like that).

Every time I try to upload a deck at https://decks.md.rereadgames.com/ it comes up saying

"Sorry, there appears to have been a problem, please try refreshing the page.

The server rejected that, please check for problems."

Describe the bug

Signing in with google does not work.

How to reproduce the bug

Steps to reproduce the behaviour:

1. Go to https://decks.rereadgames.com/sign-in
2. Click sign in with google
3. Pop up should say "Error 401: deleted_client The OAuth client was deleted."

Expected behaviour

This is supposed to open a page where you select which email you want to use to sign in.

Attachments

I get an error after deleting a deck. The deck does get deleted but right after deleting, the background turns red and it says "Sorry, there appears to have been a problem, please try refreshing the page. Unable to decode the response from the server: Problem with the given value: {} Expecting a STRING"

I have tested this on both empty decks and ones containing a few cards, I get the error regardless.

The game Massive Decks integrated with Many Decks has a pretty good localization system allowing everyone to play in their native language (along with the card decks in this language), so it'd be really nice if the Many Decks website also was localized. There wouldn't be so many strings to translate, but it might improve the experiences of foreign people creating decks.

When I'm editing a deck, sometimes the language I originally set (Italian) changes to "English", "United States"
It's not very disturbing but I'll leave the issue anyway, noone has reported it yet

Describe the bug

Going on decks, and adding a custom deck through code won't load it.
The issue is in the link it provides. for example, I want to use the deck with the code "1RGJP", and when I click on it to see if everything's ok, it redirects me to this link, please note the double forward slash before "decks":
https://decks.rereadgames.com//decks/1RGJP

It should instead search to this link.
https://decks.rereadgames.com/decks/1RGJP

edit: this issue better explains this problem.

Currently, sign in is only done via Google, it would be nice to offer alternatives.

I'd like there to be a way to authenticate with an API key (which could perhaps be generated via the website when logged into an existing account), so that it's possible to programatically modify existing decks/create new ones, without having to mess around with Google or Twitch's login features.

(as I stated in Lattyware/massivedecks#250, my motivation here is to create a discord bot that makes it possible for small communities to collaborate on a deck)