Comments (4)
themsaid
commented on May 14, 2024
1
Thanks, fixed that.
from telescope.
X-Coder264
commented on May 14, 2024
You only changed the type-hint in b46ec0f which now results in this exception (as expected) when running the prune command:
Illuminate\Contracts\Container\BindingResolutionException: Target [Laravel\Telescope\Contracts\PrunableRepository] is not instantiable.
from telescope.
themsaid
commented on May 14, 2024
I've reverted my changes 8203efb for now
from telescope.
X-Coder264
commented on May 14, 2024
I think it would be better to bind the PrunableRepository contract in TelescopeServiceProvider to the implementation. Checking with method_exists against a type-hinted contract that does not have that method while we have the proper contract seems hacky at the very least.
from telescope.
Related Issues (20)
- Log messages truncation HOT 1
- Hide sensitive information from job details HOT 3
- Load Older Entries not working on Jobs page sometimes HOT 2
- Add Elasticsearch driver HOT 1
- Add curl section HOT 1
- Telescope Entries Key Collisions Across Multiple Servers HOT 4
- Telescope is not logging Mails, Notifications, Logs from Booted Method and Model Hooks HOT 1
- query with an escaped question mark does not reflect correct bindings HOT 1
- Ability to delete data by data type HOT 2
- Job recorder memory leak HOT 9
- Changing table names in database HOT 1
- Redirect Back to Application Dashboard/Homepage HOT 1
- [Feature Request] Set timezone for IncomingEntry recorded_at HOT 1
- Call to undefined method Laravel\Telescope\Telescope::ignoreMigrations() HOT 1
- Migration file is being published with a new timestamp everytime HOT 2
- Also add a given response in the app
- User vistor's count like page wise display HOT 1
- When saving a model I use several primary_keys HOT 2
- Allowed memory size exhausted HOT 1
- Ability to set queue for ProcessPendingUpdates HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from telescope.