Giter Club home page Giter Club logo

Comments (13)

mauthi avatar mauthi commented on June 10, 2024

Also needed: Update of documentation

from localisation.

aocneanu avatar aocneanu commented on June 10, 2024

New core files are empty - I think this is OK?

By empty you mean they have all the keys and the values are null?

from localisation.

aocneanu avatar aocneanu commented on June 10, 2024

Question: Should the state of Key collector get stored locally? At the moment its Off after every reload?
Nope. We want to use this flag with care.

from localisation.

aocneanu avatar aocneanu commented on June 10, 2024

We should enso lang files to php artisan vendor:publish --force --tag='enso-assets'

Correct.

Needed Change: Add php artisan localisation:merge to composer post-update-cmd

Correct.

Do you want to make this changes or I will?

Thanks.

from localisation.

mauthi avatar mauthi commented on June 10, 2024

from localisation.

mauthi avatar mauthi commented on June 10, 2024

from localisation.

aocneanu avatar aocneanu commented on June 10, 2024

Strange. When I create a new language i get jsons with the keys and null values.

I will make the changes tomorrow, and test again.

from localisation.

mauthi avatar mauthi commented on June 10, 2024

from localisation.

aocneanu avatar aocneanu commented on June 10, 2024

the first extra()

from localisation.

aocneanu avatar aocneanu commented on June 10, 2024

Added both.

Right now, on every automatic hit on addKey a merge (all) command executes. This is not optimal. On a page with 20 new labels, and having 20 languages, the app will make 20 requests and 20*20 merges.

I think that the best solution is to cancel the logic that does the auto merge, and do the merge manually, once all the labels were gathered.

from localisation.

mauthi avatar mauthi commented on June 10, 2024

I think that the best solution is to cancel the logic that does the auto merge, and do the merge manually, once all the labels were gathered.

We can add a "merge" button to FE below "key collector switch"?

from localisation.

aocneanu avatar aocneanu commented on June 10, 2024

I think that it would fit better somewhere in the localisation structure.. maybe on the EditTexts page.

from localisation.

mauthi avatar mauthi commented on June 10, 2024

also ok

from localisation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.