Comments (6)
If you switch the language to English don't should see the key instead of the translation? Because if you do then you can filter by that key.
from localisation.
Not if we receive a screenshot from a user of a dialog that only appears in certain cases (for example)
from localisation.
It would be really useful
This is and edge case, more like it would be extremely rarely useful.
When this happen the user can still switch to en and determine the key. If he does not know how to do that and instead sends you a printscreen you can easily search by the translation in the JSON file and get the key.
But if you want to make a PR for this to implement it in a cleam manner be my guest.
from localisation.
you can easily search by the translation in the JSON file and get the key.
Those responsible for translations don't have direct access (nor proper knowledge to handle) such files though.
I'll see how cleanly I can implement it and PR if so.
Given the current structure the best implementation method would likely be to filter by value only if no results are returned (to reduce regular load)
from localisation.
Given the current structure the best implementation method would likely be to filter by value only if no results are returned (to reduce regular load)
I think that the best approach would be to filter by both (key OR value) at all times. Are you experiencing performance problems with the current filter?
from localisation.
Are you experiencing performance problems with the current filter?
No I'm not, but given the added complexity the double-filter would introduce I expect a (slightly?) noticeable slowdown for lower-end devices; This shouldn't be a big issue for the translation page itself though (less likely to be a low-end device)
I'll add it at all times
from localisation.
Related Issues (20)
- Error message for selects not translated HOT 5
- Document title not translated if 'extendedDocumentTitle' => true
- Datatable not translated HOT 2
- Language of login page HOT 2
- Datepicker in Form: Select Date not translated HOT 15
- Document title not translated after reload HOT 1
- Errors on login page (in 2.5.5) HOT 1
- Toastr title not translated on login screen HOT 7
- Translate time info in notifications HOT 1
- Don't get 2.3.7 on composer update HOT 1
- Update Tests HOT 1
- Build Factories for all relevant packages
- can_store_language expects deleted files HOT 3
- Language not set in Laravel session? HOT 2
- Support parameters in keys HOT 12
- Localisation of login/password reset HOT 2
- system.localisation.merge 404 exception
- Refactor
- [bug] Remove key from lang files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from localisation.