Giter Club home page Giter Club logo

Comments (6)

aocneanu avatar aocneanu commented on June 10, 2024

If you switch the language to English don't should see the key instead of the translation? Because if you do then you can filter by that key.

from localisation.

jlsjonas avatar jlsjonas commented on June 10, 2024

Not if we receive a screenshot from a user of a dialog that only appears in certain cases (for example)

from localisation.

aocneanu avatar aocneanu commented on June 10, 2024

It would be really useful

This is and edge case, more like it would be extremely rarely useful.

When this happen the user can still switch to en and determine the key. If he does not know how to do that and instead sends you a printscreen you can easily search by the translation in the JSON file and get the key.

But if you want to make a PR for this to implement it in a cleam manner be my guest.

from localisation.

jlsjonas avatar jlsjonas commented on June 10, 2024

you can easily search by the translation in the JSON file and get the key.

Those responsible for translations don't have direct access (nor proper knowledge to handle) such files though.
I'll see how cleanly I can implement it and PR if so.

Given the current structure the best implementation method would likely be to filter by value only if no results are returned (to reduce regular load)

from localisation.

aocneanu avatar aocneanu commented on June 10, 2024

Given the current structure the best implementation method would likely be to filter by value only if no results are returned (to reduce regular load)

I think that the best approach would be to filter by both (key OR value) at all times. Are you experiencing performance problems with the current filter?

from localisation.

jlsjonas avatar jlsjonas commented on June 10, 2024

Are you experiencing performance problems with the current filter?

No I'm not, but given the added complexity the double-filter would introduce I expect a (slightly?) noticeable slowdown for lower-end devices; This shouldn't be a big issue for the translation page itself though (less likely to be a low-end device)

I'll add it at all times

from localisation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.