laquasicinque / hotstuff Goto Github PK

Generic key listeners trigger fine on key down, but only listen to one key up event (as it's removed after the first key is released).

Not only this but events caused my key down events should probably affect the correct key up event (e.g triggering a keydown event for e and having it return false should make it so that when e is released, no key up function is called.

At the moment, when the window loses focus, all active keys are marked as released (dropped from the array). It does not, however, trigger the events of all the keyups.

We do have access to all the handlers that need to be triggered, however for them to be triggered correctly we need to provide each handler a KeyboardEvent object.

This object needs to contain fake, simulated, but accurate data, for example

• if the keydown event was listening to char a the key up event should also be for the character a
• for multiple keypresses, such as ctrl-shift-a it should be one of the valid characters (perhaps the last one pressed (ie, the one that caused the trigger).
• for hotkeys that have multiple bindings, it should be one of the valid characters for the hotkey binding that triggered it (e.g if a binding is bound to ctrl-r and alt-f, and was triggered by the former, only ctrl and f are the only acceptable values for the key up

Currently, the only way I can think of doing this is storing the keydown event and using it to make a simulated keyup event (if not using the same object and changing the timestamp and eventtype)

I'm not sure what is meant with the "select" keycode for 93.
On macOS using the right command key (⌘) triggers 93 but I think this is considered to be the meta key?

There's a bug with meta and down/up
→ when doing meta+down successively it works.
→ when doing meta+up successively it works.
→ when doing meta+down and afterwards meta+up it will start logging down+meta+up instead.
This further also breaks the recognition of the regular up key logging down after this bug has occurred.

Add the ability to provide hotkeys that accept a generic structure. Something like ctrl-<key> would listen to any keypresses that consist of ctrl and a key

This is my biggest hurdle with the library.

When I do eg. meta+up (command+up on mac) it listens once, and also on more strokes of the up-key, but once I let go the command key, hotstuff stops listening completely to anything.

I wasn't able to reproduce this on Codepen, so let me know if you want me to show in my app on my screen.

when I type the , char I get:

Uncaught TypeError: Cannot read property 'toLowerCase' of undefined
at HotStuff.handleKeyDown
Uncaught TypeError: Cannot read property 'toLowerCase' of undefined
at HotStuff.handleKeyUp

from lines:

            // perhaps refactor;
            var key = (e.which && e.keyCode ? KEYCODE_ALIAS_MAP[e.which || e.keyCode] : e.key).toLowerCase();

google chrome