Giter Club home page Giter Club logo

angular-hr-material's People

Contributors

lanzoninicola avatar

Watchers

 avatar  avatar

angular-hr-material's Issues

Duplicate HTTP request on saving entity with pipe chain

Saving an entity (eg. user) fire multiple HTTP request (the shareReplay() didn't solve the issue):

Original Code:

save(userData$: BehaviorSubject<UserFormData>): Observable<UserModel> {
   
    return userData$.pipe(
      distinctUntilChanged(),
      map((userData) => {
        return {
          firstName: userData['firstname'],
          lastName: userData['lastname'],
          email: userData['email'],
          department: userData['departments'],
          companyRoleLevel: userData['companyLevels'],
          platformRole: userData['platformRoles'],
        };
      }),
      switchMap((userModel) => {
        return this.http
          .post<UserModel>(
            `${environment.API}/users`,
            userModel,
            this.httpOptions
          )
          .pipe(catchError(this._handleError<any>('saveUser')));
      }),
      shareReplay()
    );
  }

I found another solution to this (see below) but it is interesting investigate and find a solution.

The method that sends the request accepts now an object and not the Observable, the data transformation to the UserModel schema is done before, in the save method of component.

Workaround

The save method in the service

   save(userData: UserModel): Observable<UserModel> {
    //TODO: see the issue https://github.com/lanzoninicola/angular-hr-material/issues/3]

    return this.http
      .post<UserModel>(`${environment.API}/users`, userData, this.httpOptions)
      .pipe(catchError(this._handleError<any>('saveUser')));
  }

The save method in the component

 save(userFormData: UserFormData) {
    this.userFormData$.next(userFormData);

    const userModel: UserModel = {
      firstname: userFormData['firstname'],
      lastname: userFormData['lastname'],
      email: userFormData['email'],
      department: userFormData['departments'],
      companyRoleLevel: userFormData['companyLevels'],
      platformRole: userFormData['platformRoles'],
    };

    this._usersService
      .save(userModel)
      .subscribe((newUser) => this.user$.next(newUser));

    //TODO: add user to the list
  }

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.