Giter Club home page Giter Club logo

Comments (6)

laninsky avatar laninsky commented on July 27, 2024

Hiya Ludo,

Thanks for lodging this issue - can I grab your popmap.txt file off you too? https://github.com/laninsky/GBS_SNP_filter#popmaptxt

Ta!

Alana

from gbs_snp_filter.

ldutoit avatar ldutoit commented on July 27, 2024

yes of course!

popmap.txt

from gbs_snp_filter.

laninsky avatar laninsky commented on July 27, 2024

Thanks Ludo - you've indeed found a bug in how the code handles "./." when the coverage of 0 is not explicitly given. I will do my best to fix this tomorrow and let you know :)

from gbs_snp_filter.

ldutoit avatar ldutoit commented on July 27, 2024

from gbs_snp_filter.

laninsky avatar laninsky commented on July 27, 2024

Kia ora Ludo - think I've fixed this (and a few other 'knock on' issues the fix caused :P ), and the new code now seems to be working on your dataset. However, your GBS_SNP_filter.txt file would also need to be tweaked a little to something along the lines of the following (rather than the seven line file you sent me originally):

test.vcf
0.0
1
0.05
0.5
1
#CHROM

I've added in a check to make sure that folks have enough stuff in GBS_SNP_filter.txt so hopefully this will fail at the beginning rather than half-way through in the future :) Let me know if the readme needs some more work on describing how to set up the GBS_SNP_filter.txt file, otherwise if it now seems to be working on your 'proper' dataset, let me know and I'll close this issue.

from gbs_snp_filter.

ldutoit avatar ldutoit commented on July 27, 2024

from gbs_snp_filter.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.