Comments (6)
Some advantages of the current behaviour is that it is obvious what is present within the field, and makes it easier to implement a DataItemManipulator
callback.
A possibly disadvantage @dextermb brought up is that if a relationship is added to a model, its content, which could contain private information, would be immediately rendered in the table.
Ideally, we should output something that makes it obvious the column is not empty, but does not reveal private information. Perhaps we could blank out all values, or replace their content with asterisks, leaving the keys intact, then stringify as is?
from react-dynamic-data-table.
Some advantages of the current behaviour is that it is obvious what is present within the field, and makes it easier to implement a
DataItemManipulator
callback.A possibly disadvantage @dextermb brought up is that if a relationship is added to a model, its content, which could contain private information, would be immediately rendered in the table.
Ideally, we should output something that makes it obvious the column is not empty, but does not reveal private information. Perhaps we could blank out all values, or replace their content with asterisks, leaving the keys intact, then stringify as is?
Perhaps we go through and make the values undefined
or null
. Maybe even <redacted>
.
window.<object>
or in the network tab.
from react-dynamic-data-table.
Extra thoughts, @NilesB @JacobBrassington @wheatleyjj @ash123456789
from react-dynamic-data-table.
Shouldn't data that should be redacted never make it to the front end?
from react-dynamic-data-table.
Shouldn't data that should be redacted never make it to the front end?
This issue is, that if someone were to use with
on a Laravel model, then the relationship would appear everywhere and magically appear on the frontend.
from react-dynamic-data-table.
@JacobBrassington You're very right, it shouldn't. The functionality being discussed is just an extra fail safe to ensure that even if it does somehow reach the frontend, it is not immediately displayed to casual users.
from react-dynamic-data-table.
Related Issues (20)
- Pagination not work HOT 1
- Data table components use unsafe lifecyle functions which throw warnings in the console
- Export tools
- Do not update the loading prop after the first page HOT 2
- Remove anonymous functions HOT 2
- Split DynamicDataTable into multiple components
- Do not render an empty cell if no buttons are set HOT 2
- Allow valid react elements to be used in data manipulator HOT 3
- Add the ability to order table columns HOT 1
- Do not show loading state when changing pages after the first time HOT 2
- Add the ability to disable the initial AJAX load
- Check for null before stringifying objects HOT 7
- `dataItemManipulator` prop not documented fully
- Add `disabled` or `loading` attribute to buttons
- Add all supported props to prop types for the AjaxDynamicDataTable. HOT 3
- Unable to do Bulk select HOT 4
- Update propTypes on DataRow to use valid prop type function HOT 2
- Update defaultProps for `buttons` on DataTable HOT 2
- Default value for `buttons` prop does not handle query strings HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-dynamic-data-table.