SapiEmitter::emitBody() suppresses exceptions by using StreamInterface::__toString() about laminas-diactoros HOT 5 CLOSED

It just occurred to me - why is emitBody() converting the stream to a string in the first place? Isn't the whole point of a stream that it can be streamed?

$stream = $response->getBody();
if ($stream->isSeekable()) {
    $stream->rewind();
}
while (!$stream->eof()) {
    echo $stream->read(1048576);
}

Originally posted by @jesseschalken at zendframework/zend-diactoros#181 (comment)

from laminas-diactoros.

I performed a ton of benchmarks when developing psr-7 that indicated that
when dumping the entire stream at once, the implementation in
__toString() tends to be most performant for payloads falling within
average web page and API payload sizes. You can always create alternate
emitters if your needs are different.
On Jun 21, 2016 9:39 PM, "Jesse Schalken" [email protected] wrote:

It just occurred to me - why is emitBody() converting the stream to a
string in the first place? Isn't the whole point a stream that it can be
streamed?

$stream = $response->getBody();if ($stream->isSeekable()) { $stream->rewind();}while (!$stream->eof()) { echo $stream->read(1048576);}

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
zendframework/zend-diactoros#181 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AABlV7UxnPQGXcCCXOnCGJD4pr8XxuOoks5qOKBGgaJpZM4I6cvi
.

Originally posted by @weierophinney at zendframework/zend-diactoros#181 (comment)

from laminas-diactoros.

Doesn't everybody "need" their exceptions not to be ignored? Isn't that why they throw exceptions?

Originally posted by @jesseschalken at zendframework/zend-diactoros#181 (comment)

from laminas-diactoros.

Moreover, toString always returns an empty string when isSeekable is false due to the unchecked call to rewind there. I don't think toString should be used in SapiEmitter either.

Originally posted by @Venorcis at zendframework/zend-diactoros#181 (comment)

from laminas-diactoros.

SapiEmitter no longer part of laminas-diactoros

from laminas-diactoros.