[RFC]: Remove `scheme` filtering about laminas-diactoros HOT 3 CLOSED

One important consideration: PSR-7 packages are about abstracting HTTP messaging, so that needs to be considered upfront.

I'm fine with the proposal, just throwing in this data point.

from laminas-diactoros.

My takes:

• PSR-7 very explicitly states: "UriInterface models HTTP and HTTPS URIs as specified in RFC 3986 (the primary use case)". When developing PSR-7, there was some discussion about modeling any URI, and we chose NOT to do this, as there are a number of URIs that are formed quite differently; many would NOT work in an HTTP context. The consensus was that something targeting all of RFC 3986 would need a separate PSR, and that most likely if we abstracted only HTTP/HTTPS URIs, it could likely later extend such a PSR and still retain compatibility with PSR-7.
• Technically, if other PSR-7 implementations are supporting anything other than HTTP/HTTPS in their UriInterface implementations, they are deviating.
• All that said, I have no problem with changing this, but we need to be careful to note that our implementation does NOT cover all of RFC 3986, and that it's potentially possible to obtain and/or construct a URI that cannot be used within your application.

from laminas-diactoros.

After some more thoughts (including the knowledge I've gathered from Marcos and Matthews comments), I decided to tackle the underlying issue in mezzio-cors.

To summarize:

• diactoros does follow PSR-7 specs
• diactoros does not allow more than HTTP/HTTPS and is not required to do so (as per PSR-7 spec)
• PSR-7 spec allows other schemes than HTTP/HTTPS but also states that implementation MAY NOT implement that
• PSR-7 spec actually states that RequestInterface#withScheme may throw InvalidArgumentException for unsupported schemes

Thanks for the feedback here and in Slack.

from laminas-diactoros.