Giter Club home page Giter Club logo

songsync's Introduction

Stats

Lambada10's github stats

Languages

Top Langs

Trophies

trophy

Views

songsync's People

Contributors

akanetan avatar bobbyesp avatar fabirich avatar izzysoft avatar lambada10 avatar mikropsoft avatar mrgaboz avatar nift4 avatar peter9811 avatar weblate avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

songsync's Issues

extra dot in file name

in some cases lrc files will have this method of naming
file-name..lrc
the app will add an extra dot before file extension which prevent detecting lrc in music players

App can't find lyrics sometimes

Describe the bug
App throws error, when trying to find a lyrics for song. But sometimes it randomly finds lyrics.

To Reproduce
Steps to reproduce the behavior:
Just search for any song in "Browse" label. Or select any song from library.

Expected behavior
App should find the lyrics.

Screenshots
Screenshot_2023-08-03-19-35-22-503_pl lambada songsync

Smartphone (please complete the following information):

  • Device: Poco X3 Pro
  • OS: MIUI 13 (Android 12)
  • App version 2.1.0

Additional context
I'm from Russia and Spotify requires login to work there. I still have tried to search lyrics with VPN, it worked somehow for once, but next attempts failed.

Embed lyrics

I have a plenty of beautiful songs
Having lots of lrc files just don't what I want as I'm searching for something that i can embed lrc files to my audio files (mp3,flac etc.)

Error gettings lyrics

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Songsync app'
  2. Click on '.search box'
  3. Tye Song name:"Flower" and artist name: "Jisoo"
  4. See error: No lyrics

Expected behavior
Lyrics are available.

Screenshots
Screenshot_20231018-173855_Chrome

Smartphone (please complete the following information):

  • Device: [e.g. Samsung Galaxy S10, Poco X3 Pro]
  • OS: [e.g. MIUI 13 (Android 12), Pixel Experience 13]
  • App version [e.g. v1.3]

Additional context
Add any other context about the problem here.

The 'select all' button selects tracks which are filtered out.

Describe the bug
If we go into selection mode and use the 'select all' button when any of the two filters are turned on ('Only show songs without lyrics' or 'Ignore Folders') the app selects every audio file it can recognise in the phone storage; even the ones inside the ignored folders.

Manually adding a .nomedia file to these ignored folders and reopening the app did decrease the total file count.

To Reproduce
Steps to reproduce the behavior:

  1. Open the app and select one song by long pressing it to go into selection mode. On the top right corner click the select all button (the one without the cross). Check the total number of songs selected.
  2. Cancel the selection and turn on any of the two filters.
  3. Repeat step 1 with the filter turned on.
  4. Recheck total number of songs selected. The number of songs selected will remain unchanged.

Expected behavior
When using this option it is expected that only the songs being shown on the screen will be selected.

Screenshots
05 11 23_SongSync_Bug
The before and after results with 'Only show songs without lyrics' filter toggled on and off respectively.

Smartphone (please complete the following information):

  • Device: Mi 11
  • OS: MIUI 13 (Android 12)
  • App version: v3.0.0

Additional Context
The app also crashes a lot when selecting multiple songs one by one.

App stopped working altogether

Describe the bug
App cant find lyrics

To Reproduce
Steps to reproduce the behavior:
Search for any song's lyrics

Expected behavior
Finds lyrics

Smartphone (please complete the following information):
Any

Additional context
Stopped working a couple of days ago

Lyrics by link

A cool thing to have is the ability to download the lyric from a link because the search doesn't always work

Switch to a different Lyrics Provider automatically when one fails.

Most of the time Spotify doesn't have lyrics or it can't be fetched probably because of the unreliable API. So a feature where the app automatically searches with the other Lyrics providers when the previous one fails would be very useful because switching back and forth three times for a single song/track is a bit frustrating. ๐Ÿ‘

Netease error

The Netease lyrics source doesn't work at all and only throws errors (similar behavior currently also in LRCLib).

Steps to reproduce the behavior:

  1. In "About" tab, select "Netease" source
  2. Try to search for any lyrics in "Browse" tab
  3. The error pop-ups on the screen

The program was supposed to fetch the desired lyrics, but it had thrown an error instead.

Screenshots:
Screenshot_20240507_224150.jpg

Smartphone:

  • Device: Huawei P20
  • OS: EMUI 12 (Android 10)
  • App version v3.0.2

This issue is very important because Spotify has currently limited its Lyrics to premium users only and the app won't work without a working source of lyrics.

App Icon Not Visible

Describe the bug

App Icon Not Visible on the app menu .
Smartphone (please complete the following information):

  • Device: Asus Zenfone Max pro m1
  • OS: Pixel Experience 10
  • App version : 2.2.0(220)

Screenshot_20230825-105209_Trebuchet (1)

Batch Download immediately gets rate limited and aborts

Describe the bug
When using the Batch Download feature, it downloads about 4 songs and then tells me it's reached Spotify's rate limit and stops. I don't see any way to adjust the speed at which it downloads the songs to avoid hitting the rate limit or let it retry.

To Reproduce
Steps to reproduce the behavior:

  1. Open the app, which shows you the home page.
  2. Click on 'Batch download lyrics'.
  3. Let it download for about 4 songs.
  4. See 'Spotify rate limit reached. Please try again later'.

Expected behavior
My lyrics get downloaded, and are retried if they hit the rate limit and back off the speed until there are no issues

Screenshots
IMG_20230803_061334

Smartphone (please complete the following information):

  • Device: [Google Pixel 4a]
  • OS: [GrapheneOS v2023072600]
  • App version [2.1.0]

Additional context
My library has 6k songs. This happened the very first time I tried downloading any lyrics.

Possibility of Creating a Windows Version of SongSync App

I've been using your GitHub app, SongSync (https://github.com/Lambada10/SongSync), and I'm quite impressed with its features for managing music libraries and downloading lyrics.

I'd like to suggest the possibility of creating a Windows version of SongSync. Currently available for Android, the app's features could be really beneficial for Windows users as well. Many people use Windows for their music collections and having a dedicated app like SongSync would be great.

Expanding SongSync to Windows could have some key advantages:

Broader User Base: You'd tap into a new audience of Windows users looking for music management and lyric download solutions.

Consistency: Offering a consistent experience across different platforms can contribute to user loyalty.

Leveraging GitHub: Since the app is already on GitHub, development for the Windows version could happen right there, making it easier to collaborate and maintain.

Consider looking into the technical feasibility of adapting the app to run on Windows. If feasible, this could be a valuable addition to your project.

Thank you for considering this suggestion.

App requires internet access

Describe the bug
A clear and concise description of what the bug is.
I wanna go inside the app but I can't cause the app says I have no connection
To Reproduce
Steps to reproduce the behavior:
Open the app
Expected behavior
A clear and concise description of what you expected to happen.
Opens the app but won't allow you to download or search for lyrics since you have no internet (instead the app closes with a message that you have no internet or Spotify is down)
Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: [e.g. Samsung Galaxy S10, Poco X3 Pro]
  • OS: [e.g. MIUI 13 (Android 12), Pixel Experience 13]
  • App version [e.g. v1.3]

Additional context
Add any other context about the problem here.

Sync Song info as well

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

It is not connected to a problem but an enhancement request. How about changing the song infos as well?

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Downloads wrong lyrics

Describe the bug
A clear and concise description of what the bug is.

Sometimes it's a completely different song's lyrics, sometimes it's from the same album but wrong file name

To Reproduce
Steps to reproduce the behavior:

  1. Batch download
  2. See error

Expected behavior
A clear and concise description of what you expected to happen.

Correct lyrics

Screenshots
If applicable, add screenshots to help explain your problem.

Screenshot_20230807-134240_Material Files.png

Song from same album but with wrong filename

Smartphone (please complete the following information):

  • Device: Razer phone 2
  • OS: lineage microg 20
  • App version 2.2.0

Additional context
Add any other context about the problem here.

Crashes when switching to home

Describe the bug
A clear and concise description of what the bug is.
Crashes when returning to home page after saving lyrics from search for lyrics song
To Reproduce
Steps to reproduce the behavior:
Press any song, search for lyrics with him and save lyrics then press on home button
Expected behavior
A clear and concise description of what you expected to happen.
Should return to home and show you all other songs
Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: A72
  • OS: lineage os a13
  • App version 3.0.1

Additional context
Add any other context about the problem here.
Crash logs crash-pl-lambada-songsync-21_02-09-00-56_896.zip

The app crashes at startup

Describe the bug
In previous version 2.2.0, when there was no Internet connection (no mobile data or wifi), the message "no internet connection" was displayed when the app was launched. However in version 3.0.0, the app crashes in this case.

To Reproduce
Steps to reproduce the behavior:

  1. Be sure that the phone is offline.
  2. Try to launch the app.

Expected behavior
The "no internet connection" message present in 2.2.0 should be displayed in 3.0.0 instead of a crash occurring.

Smartphone (please complete the following information):

  • Device: Samsung A54
  • OS: Android 13
  • App version 3.0.0

Additional context
Thank you very much for this great app ;-)

App available at F-Droid as well

Describe the bug
It seems that the README has just one source to download - IzzyOnDroid

Expected behavior
Someone didn't know that the app was also on F-Droid, the app store I downloaded SongSync

Screenshots
[Lil bit later]

Smartphone (please complete the following information):

  • Device: Redmi Note 9
  • OS: MIUI 13 (Android 12) [bruh that example was the exact one needed ๐Ÿ’€]
  • App version: README.md, commit f1a1297

Additional context
Gramophone is also an app from the guys in this team

[v3.0.1] App crashes if you exclude songs with lyrics and remove a folder (example: whatsapp audios) from the search.

Description:
The app crashes if you toogle "Show only songs without lyrics" and ignore a folder (i don't know if is any folder or just WhatsApp Audio). This forces the user to unistall the program because it crashes immediately on use (it shows for a split second the audio files from the ignored folder).

Reproduce (the name of the feature may be a little different because im using in portuguese):
Steps to reproduce the behavior:

  1. Go to Filters;
  2. Toggle "Show only songs without lyrics;
  3. Go to "Ignore folders"
  4. Select WhatsApp Audio, or any other folder that contains an audio file.

Expected behavior
That both filters work together.

Screenshots
Crashes immediately so no screenshots :(

Smartphone (please complete the following information):

  • Device: Samsung Samsung Galaxy A03s
  • OS: Android 13
  • App version v3.0.1

Additional context
I only have a few folders with audio files. One dedicated to music (but each album is in one dedicated folder) and the WhatsApp one.
All permission that the app asked were given.
Sorry any typo/grammar, english is not my first language.

Download Failed To Fetch Lyrics

I really appreciate an app that downloads the lyrics of songs on our device.

So I just went through the scan and all of my music except 2 songs were successful. I checked and couldn't find the 2 successful ones too.

Is there a way to pick where the lyrics are taken from? I don't see any settings for this.

Looking forward to a working version of this where I can save all my music lyrics offline.

Thanks

Filter using file directory

Is your feature request related to a problem? Please describe.
Kinda, I have a lot of audio files, most aren't music .

Describe the solution you'd like
It would be good to have a way to filter by blaclisting or whitelisting directories.

Swap Spotify API

Is your feature request related to a problem? Please describe.
Spotify is greedy and made lyrics a premium only feature

Describe the solution you'd like
Switch the API to MusixMatch or Genius

Copy browsed lyrics

It would be so helpful if you add an option to simply copy the lyrics which I found either in home with am existing song or a lyrics which it searched through browse tab

Crashing When Saving Lyrics

Describe the bug
When choosing to save the lrc file, the app crashes

To Reproduce
Steps to reproduce the behavior:
Search for a song and choose to save the .lrc file

Expected behavior
It should save the file to my songs folder, the same folder that my music files are stored in

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: Motorola G Stylus (2021)/ moto g stylus (XT2115DL)
  • OS: Android 11
  • App version: 3.0.0

Additional context
The app worked perfectly for the first three or so songs I tried to use. I'm using the Spotify provider. This happens when using the app installed straight from GitHub and from F-Droid

Edit: I noticed that this behavior only happens when I search for the song directly through the browse tab. If I choose the song from the home tab, it works

Randomly added "."

Describe the bug
A period (.) randomly added when saving?

To Reproduce
Steps to reproduce the behavior:

  1. Go to home
  2. Search local song click on save .lrc file
  3. go to my files where local song is saved
  4. find lrc file shows like this Songname..lrc

Expected behavior
should be Songname.lrc

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: [Samsung Galaxy S21 FE 5G]
  • OS: [Android 12/android 13]
  • App version [3.00]

Question on storage permissions

My scanner just got "revamped" last week, and immediately found something to say about (not just) your app:

! repo/pl.lambada.songsync_301.apk declares risky permission(s): android.permission.READ_EXTERNAL_STORAGE android.permission.MANAGE_EXTERNAL_STORAGE

Could you please clarify what those permissions are needed for? Especially the latter, as that's usually reserved for applications like e.g. file managers. Thanks in advance!

LRC generator app suggestion

This issue not for SongSync, but to suggest you an app to make because

  • some songs in Spotify don't have synced lyrics(LRC)
  • and currently SpotifyLyricsAPI broken anyway

Would you consider making a simple app that generates LRC out of lyrics plaintext? Something similar to https://github.com/DBKarman/lyricsync but as an app.

Here's how this works

  • Enter lyrics
  • Choose the song
  • Now the song start playing
  • Sync each lines as the singer sings
  • An LRC generated in the end
  • Pretty neat, isn't it?

Thanks

possibility to search by approximate names

If you can't find lyrics by exact names the possibility to search by approximate names. That is, not "waste" but "Wast3", or not "gangnam style remix zyzy" but "gangnam style ^-^remix^-^ by ZyZy!!!!!". or just, not "come on", but "come on!"

it's useful when I have a lot of remixes, but different sources spell them differently, or their lyrics match the original.

Crash after searching by track name and going back/home

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: [e.g. Samsung Galaxy S10, Poco X3 Pro]
  • OS: [e.g. MIUI 13 (Android 12), Pixel Experience 13]
  • App version [e.g. v1.3]

Additional context
Add any other context about the problem here.
https://bin.kv2.dev/~661477e65de7ed6bfdc1314d

[major] crashing issue

Describe the bug
When I exclude folders from the search and reopen the app, it crashes and refuses to launch until I clear data.

To Reproduce
Steps to reproduce the behavior:
exactly what was described

Expected behavior
App opens

Smartphone (please complete the following information):

  • Device: Poco M3
  • OS: MIUI 14 (Android 12)
  • App version: 3.0.0

Won't start

I'm using Android 13 Custom ROM
Installed the app but it will crash immediately after i run it

Adjust lyrics speed

@Lambada10 I was wondering if its possible for you to add a feature that allows you to adjust the speed in which a lyric sync with songs, like exponentially increasing or decreasing the delay between each line of a lyric.
I think this would be really useful in applying synced lyrics to slowed and sped up versions of different song, because alot songs sounds better woth their sped or slowed counterparts
An adjusting slider/meter would be preferred or a preset or however you do it, I don't mind. I just think it would be a pretty nice feature to implement

Ability to write to external storage, embed lyrics and browse to a music folder.

Screenshot_20230806-102803

  1. Please enable support for saving lyrics file into into external storage, as I (and I'm sure many others as well) have their music files stored in SD card. (My phone is android 9)

  2. Add options to embedd lyrics directly into the music file in addition to the ".lrc" option. In that way, one wouldn't have to copy the browsed lyrics to go and manually embed in the music.

  3. Add option to actually browse and select a particular local folder in which the songs are. Having to go through "ignore" folders could be an headache especially when you have tons of subfolder (including those under internal storage and external storage) where musics are located and grouped as either different playlists, albums etc

  4. Black/Dark theme appearance option pleaseeeee! :)

Great Job dev, keep it up.
An app like yours is what I've been looking for for a while now to complement my musicolet app. I'm sure many musicolet users also share my sentiments. Your app could be the next big thing in the "SYNCED" offline lyrics niche just as musicolet has been for the offline music niche.

SpotifyLyricsAPI is no longer working.

Describe the bug
Spotify changed something in their API which results in no lyric found by the app.

To Reproduce
Try any song.

Expected behavior
Lyric to show up and download.

Screenshots
Nope

Smartphone (please complete the following information):

  • Device: [Xiaomi Rendi Note 3]
  • OS: [ColtOS 6.7, Android 10]
  • App version [2.2.0]

Additional context
Someone posted a workaround on SpotifyLyricsAPI github issues. It involves reformatting the code to catch the token or something.

Option to sort songs by "last added"

Is your feature request related to a problem? Please describe.
Because most of the times when you open the app you want to select the newest songs anyway. It's just extra step to search for them one by one.

Describe the solution you'd like
Add a option to sort songs by "last added" so new tracks show up on the top

Add different ways to categorize and view song files

Is your feature request related to a problem? Please describe.
Currently the app loads every single song at once which may work if you only have a few a songs but it's a nightmare if you have 4000+ song files like I have. Whenever I try to use the search feature the app starts to slow down or crash trying to look through every filename to make the query. I also can't scroll down alphabetically since it takes way too long and each time I leave the app it goes back to the top. Ignoring folders does help a bit, but even that's a bit of pain with having to constantly scroll or to try and remember which albums have songs with lyrics or not

Describe the solution you'd like
It would be nice if it was cataloged a bit more orderly, like being able to select by artist, album, or folder would be nice instead of having to constantly load every single song at once. It would basically have the same layout as a music explorer would. Clicking on and specific album would only show songs from that album that you can than filter by songs that already have lyric files and select the ones to bulk download.

Ideally it would be nice if it does show all songs that there's a side bar to quickly jump to a specific letter of the alphabet

Describe alternatives you've considered
Another possibility is to just have a file explorer option. Basically navigate to the folder you want to look in and then scan recursively. Once your down you can quick go back go the explorer and pick a new folder, etc.

Additional context
I'm using Android 11 btw

Here's some screenshots from an app called AutomaTag to get idea of what I'm talking about

Screenshot_20240306-203833_AutomaTag
Screenshot_20240306-203820_AutomaTag
Screenshot_20240306-203810_AutomaTag

Fails to download all remaining lyrics upon app aspect ratio change.

When app is in splitscreen mode with another app on the left/right, or is in pop-up (floating on top) mode, and you resize it, it fails to find the rest of the lyrics in batch download mode, immediately.

Steps to reproduce the behavior:

  1. Put app in splitscreen or pop-up mode via "recents" navbar button.
  2. Start batch download of lyrics.
  3. Change aspect ratio of app.
  4. Lyric downloading fails.

The expected behavior is that nothing should happen, as I'm not closing the app.

Samsung Tab S7 +
Android 13
v3.0.1

Filter and blacklisted folders reset upon closing the app

Describe the bug
Title

To Reproduce
Steps to reproduce the behavior:
Use filter to not show songs with lyrics or/and blacklist a folder
Close the app
Open the app

Expected behavior
A clear and concise description of what you expected to happen.
The app remembers Filter and blacklisted folders
(That doesn't happen)

Smartphone (please complete the following information):

  • Device: [e.g. Samsung Galaxy S10, Poco X3 Pro]
  • OS: [e.g. MIUI 13 (Android 12), Pixel Experience 13]
  • App version [e.g. v1.3]
    Doesn't matter, if wanted I'll give them

an option to download translated lyrics

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
Let's say the song is in Japanese so when I look for lyrics it would be awesome if there is an option to download for example the English lyrics (synced preferably)

Describe alternatives you've considered
The alternative would be me manually editing the lyrics and swapping it with the translated lyrics

Additional context
I believe apps like Musixmatch already offers multiple languages for the lyrics (if available)

Proxy settings

Hi, thanks for developing this app.
Please add the proxy settings to this app.
Like Telegram, AntennaPod, InnerTune, F-Droid and etc.

Screenshot_2023-11-01-18-11-22-518_org.telegram.messenger.web.jpg

The Spotify service is blocked in my country.

Allow users to put their own API key

Is your feature request related to a problem? Please describe.
I'm always frustrated when I get rate limited all the time
Describe the solution you'd like
Allow us to put our own API key so that won't happen

Internal error when using LRCLib

Describe the bug
LCRLib gives error when using.
To Reproduce
Steps to reproduce the behavior;

  1. Select LCRLib as source;
  2. Try to fetch lyrics for any song.
  3. See error

Expected behavior
SongSync should be able to get lyrics without giving an error.

Screenshots
Screenshot_20240502-045121_SongSync

Smartphone (please complete the following information):

  • Device: Samsung Galaxy Note 8
  • OS: Android 10
  • App version: 3.0.2

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.