lafikl / fluent Goto Github PK

*http.Client objects are designed to be re-used, as they maintain a pool of TCP connections and all sorts of other goodies; allocating a new one on every request introduces all sorts of unnecessary overhead.

You should probably just use http.DefaultClient as your client for requests, as it is thread-safe and provides sane defaults. Alternatively, you could have the user provide an http.Client to wrap.

I am using a single http client for multiple workers which is recommended by the net/http documentation. Now I want to use your package but there is no exposed function which does that. Send creates its own object every single time!
Please provide a send function with a *http.Client parameter

Seems broken if retries is used with body, as io.Reader won't rewind...

I haven't tried it... but that seems problematic... Maybe it's better to not support streams to avoid bugs.

Or am I missing something?

package main

import "github.com/lafikl/go-fluent"

func main() {
    _ = fluent.New() // I had to check your source to know the package name
}

Not everyone does this, but the convention is to have the final segment of the import path to match the package name.

github.com/lafikl/go-fluent -> github.com/lafikl/fluent