l2- / template-plugin Goto Github PK
View Code? Open in Web Editor NEWLicense: BSD 2-Clause "Simplified" License
License: BSD 2-Clause "Simplified" License
The XP drop becomes redundant screen clutter when pking and using hit prediction, could we possibly have an option to hide XP drops when using hit prediction? I tried setting time until disappear to 0, but this still caused it to flash occasionally, which was distracting.
Thanks again, amazing plugin.
FINALLY Awesome plugin! Been waiting for ever for someone to make this.
Can you add an option to add a "+" instead of skill icon in front of the number and a "space" followed by "xp" at the end of the drop?
So it would be "+(xpdrop) xp"
Example - https://streamable.com/u8ppz
I am trying to get my xp drops to pre eoc xp drops as they look aesthetic.
been doing my farm runs for a while when I noticed this text being appended to the xp drop, its not the text color though as any changes to that do not reflect to the appended text:
i have not made any changes to the plugins settings nor have I installed any plugins on RL that may conflict with this plugin. resetting RL does not make this issue go away either
and in case you want to know: here are my settings.
Fixed
I've been adding blank spaces to the prefix and suffix to make the xp drops text a little more spaced out. It works great but after closing runelite and reopening it will truncate all the empty spaces and only leave the normal text that I had in the prefix/suffix boxes. I am trying the blank space character (ALT + 255 "ย ") and will let you know if that also gets removed
When config.attachToTarget is true, the xp drops will be attached to the players target while in combat. I like to enable this setting because it subjectively feels like that's where the xp drops should be displayed. However, I find it kind of strange to not have the xp drops not near the center of the screen when in ranged (not melee) combat.
I'd like to propose a similar setting that checks the selected attack style and uses that information to determine where to display the xp drop. If the player has a melee style selected, attach the drops to the target, otherwise attach it to the player.
I'd be happy to put in a PR for this myself but wanted to gauge opinions beforehand. Thanks for your input!
This is with the following settings: (And using darts on rapid)
I've played around with the timings of all relevant settings and I cannot find a good way to avoid this issue. When the hits are spaced out this is not an issue, only after 3+ consecutive hits do the numbers start severely overlapping as shown. It seems to be a specific issue with predicted hits as the XP drops don't overlap with each other, only the predicted hit and XP overlap with each other.
It would be nice if the respective style (magic, range, melee) icon still showed up with predicted hit on.
when you have the plug-in set to separate xp drops the xp drops overlap each other and cant make out what the drop is. when you group the xp drops its fine
Currently the option to group xp drops is all or nothing, so if I want to group up all 4 xp drops from using DHL I also need to group the wc/fm drops when skilling with infernal axe.
I'd like the "Group XP Drop" setting to be changed from a checkbox to a picklist between "All, combat only or skills only"
please let us show 0xp for range and melee when we hit 0. thanks.
2022-10-23 09:05:29 [Client] WARN n.r.c.ui.overlay.OverlayRenderer - Error during overlay rendering
java.lang.StringIndexOutOfBoundsException: begin 0, end -1, length 1
at java.base/java.lang.String.checkBoundsBeginEnd(Unknown Source)
at java.base/java.lang.String.substring(Unknown Source)
at com.xpdrops.overlay.TextComponentWithAlpha.render(TextComponentWithAlpha.java:63)
at com.xpdrops.overlay.XpDropOverlayUtilities.drawText(XpDropOverlayUtilities.java:192)
at com.xpdrops.overlay.XpDropOverlay.drawXpDrops(XpDropOverlay.java:96)
at com.xpdrops.overlay.XpDropOverlay.render(XpDropOverlay.java:40)
at net.runelite.client.ui.overlay.OverlayRenderer.safeRender(OverlayRenderer.java:719)
at net.runelite.client.ui.overlay.OverlayRenderer.renderOverlays(OverlayRenderer.java:322)
at net.runelite.client.ui.overlay.OverlayRenderer.renderAfterInterface(OverlayRenderer.java:236)
at net.runelite.client.callback.Hooks.drawInterface(Hooks.java:522)
at client.ov(client.java:541)
at jd.jk(jd.java:10789)
at ao.jn(ao.java:10296)
at client.ho(client.java:4495)
at client.av(client.java:1215)
at ae.aj(ae.java:415)
at ae.run(ae.java:369)
at java.base/java.lang.Thread.run(Unknown Source)
hey, i was wondering if there is any issue with the plugin? today its just stopped working tried turning it off and on and it didnt change anything,normal xp drops works tho
Just want to say this plugin is fantastic and you've done great work OP. You fixed that last bug really fast and I respect you for that. Since I know you're alive, I thought I might as well just post this request since it's something I find would be really useful for those learning to 1-flick prayers
The other XP Drops plugin (doesn't allow customization to the same level as yours) has the ability to change the color of the xp drop when the attack is affected by a prayer boost, can you add this option here as well? That way I don't have to switch to the other plugin if I'm trying to practice flicking. Thanks
I may take a stab at implementing myself but I'm not sure, never worked on a runelite plugin before
Hey! Love the plugin! I've been using it for a while and had no issues so far until I turned on predicted hits and noticed that it shared the same custom prefix/suffix as the XP drops. This makes it a bit weird as seen on the provided screenshot. Is there any possibilities to implement a custom prefix/suffix system like the XP drops, but for the predicted hits?
Thanks!
right now its just floating around some where. yesterday iit was working fine. now its not working. its floating some where of screen. maybe the new update broke it
Hey got a sick gif for xp drop example - https://i.imgur.com/QK9qekM.mp4
can you change the first image with farm patch one with this gif and also update the section on runelite so more people can see it
Would it be possible to add an option filters the predicted hit based on what style you are using? I would like to hide the predicted hit ffor melee since its almost always pretty instant anyway, however it would be nice to have it so the predicted hit shows up for magic and ranged since they have a potentially long delay.
I've typed BankGothic to the font box and it doesnt change. Any ideas whats wrong?
currently, both XP drops and damage are displayed. is it possible to add a feature that replaces the XP drop with the damage, similar to what the instantdamagecalculator plugin does
?
With this option, whenever you hit your maximum hit in your currently equipped gear (offensive prayers such as piety and rigour included in calculation), the color of the xp drop would show up differently to quickly indicate to the player that they have gotten a max hit.
It's not much, but I have however included the code for how I think the XpDropsConfig.java
file would change.
@ConfigItem(
keyName = "xpDropColorMax",
name = "Xp drop color max",
description = "Color of the XP drop text when hitting your max hit",
position = 11,
section = xp_drop_settings
)
default Color xpDropColorMax()
{
return Color.WHITE;
}
Some special cases to consider would be things such as salve amulet against undead creatures, dragon hunter weapons against Vorkath, Olm, etc.. and some other niche cases probably exist im sure. I would try to implement this myself and send a push request, but I'm not sure how to calculate the max possible hit of someone's current gear.
Can we make the Icons pull from the resource pack settings?
Current - https://imgur.com/a/0rdBij0
With Resource packs - https://imgur.com/a/p8z5mnf
The xp drops were speeding up when I first installed them and now they are slowing down way slower than what I have them after tweaking them for awhile. They were perfect for couple hours and now are super slow for some reason.
My xp drops arent showing other than skilling drops.
Hi,
Currently, when you attack with a magic or ranged weapon on Longrange while praying melee offensive prayers (piety etc.), it will recolour the xp drop to the melee offensive prayer colour (I assume because of the defence XP). This doesn't happen on non-longrange styles. I think it should default back to the default colour when this happens, like it does on accurate and rapid attack styles.
i didnt know where i could put a suggestion.
could you add a feature to convert the combat xp drop to the amount of damage the hit is going to deal?
Such a great plugin, but found a small issue, filtering hitpoints breaks hit prediction.
Keep up the great work ๐
Below is an issue the suffix/prefix aren't centered they go to the right side of screen. Is there a way to fix this?
https://i.imgur.com/HxkSx0b.jpg
So it looks like v1.5.4 of the plugin made it so that Hide XP drops in game makes this plugin hide XP drops.
I liked the behavior prior to this version where I used Hide XP drops in game to hide the progress bar, but used this plugin to show the XP drops anyway.
Can we add an option to always show XP drops no matter what the game setting is?
xp drops aren't showing up at all with the latest update
This is a small, dumb and very niche issue, but it just gets the best of me due to my OCD.
I love the predicted hit feature. The main use for combat xp drops for me was to know when I was gonna land a hit.
Now I know when I'm gonna land a hit, and 99.9% of the time I know how much exactly it will hit.
The only problem is I don't like the clutter of predicted hit + skill xp drops, so I filtered out the xp drops for combat stats.
However, this had the side effect of not coloring the predicted hit based on which combat style I'm hitting anymore.
I would love to be able to filter out combat stats xp drops, have predicted hit on and have it be recolored based on the combat style I'm using.
This would also help me know when I've correctly got my boosting prayers on, or when I accidentally forget to turn them on after they've been disabled.
I thought I might give it a shot and create a request.
Below are some images to further clarify.
Only snaps to green boxes, was able to move around entire screen before.
Would be very useful for pking, as you don't care about the XP drops and just want to see the hit
I have the plugin set to hide hitpoints. When I relaunch the client, the hitpoints reappear. I have to go into "Skills to filter" and press enter every time to get hitpoints to hide agian.
From my testing this is something minor and it might have something to do with Runelite/programming.
The suffix is not saving the (space) in "(space)xp" and when you restart Runelite it changes back to "xp". Not a big deal I retype the (space) in front whenever I open a Runelite and its good to go.
Using this sexy font right now got a sick pic too add to the plugin info
Could you add the ability to configure a position offset when attached to the player?
When one gets more than the combat skill's XP drop in the same game tick, the XP drop isn't recoloured.
I.E. Melee XP drop when casting a mage spell (e.g. venge), Melee XP drop when cannon fires.
Amazing work so far on the plugin. Would be awesome if you could implement options to change the hit splats in combat for size, font & colors,.. ?
Thanks!
I want this font: https://www.reddit.com/r/2007scape/comments/ojepcx/comment/h516xk9/?utm_source=share&utm_medium=web2x&context=3
But it instead gives me a default font, same case with a lot of other fonts. Ones which seems to work are Impact, Georgia, Times New Roman, Arial. Probably some others
Thanks.
Idk if I'm missing something, after the recent fix to the <col #####> now my predicted hit text is always white unless overrridden. Previously it would adopt your base XP drop colours/active prayer colours
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.