kyetter / ansible-devspace-demo Goto Github PK

Can we deprecate / archive the repo in favor of https://github.com/redhat-developer-demos/ansible-devspaces-demo that is used in the learning path - https://developers.redhat.com/learn/openshift/streamline-automation-openshift-dev-spaces-ansible
some people are still tying to use this repo which creates confusion

Updates to the Dockerfile or files added into the container as part of the build should be handled as part of a Github action and published to quay.io.

The base image doesn't contain the 'oc' binary. It is added as part of the demo.oc_connection molecule prepare stage, but that is the wrong place to fix it. Prepare is run and sets things up, but it doesn't reload the PATH env in a way that it works in that same run.

It would be preferred that the oc binary is grabbed from the local cluster rather than packaging it in the image for several reasons.

1. Avoids bloating the image
2. Ensures the client and server versions of OpenShift match
3. Leverages a service of OCP that is consistent across every deployment

Rather than having the the prepare stage of molecule setup the system, it would be better if it could be handled as part of an initialization script. If there is a way to add scripts to the dev space configuration file to run-once, the jobs in the prepare stage could be moved to a simple playbook / script.

The backup_file role is setup nicely to demonstrate a simple test driven development example by adding verification to the role.

This would involve adding code to the molecule/default/verify.yml file like this.

---
- name: Verify
  hosts: all
  connection: community.okd.oc
  gather_facts: false
  tasks:
  
  - name: Check if backup file was created
    ansible.builtin.stat:
      path: "{{ backup_file_destination_path }}"
    register: __backup_file_verify_file

  - name: Debug backup file variable
    ansible.builtin.debug:
      var: __backup_file_verify_file

  - name: Example assertion
    ansible.builtin.assert:
      that:
        - __backup_file_verify_file.stat.exists

This assumes that the backup_file_destination_path is defined. The playbook will fail if this isn't defined (which is another verification that could be added). Or it can be defined in the molecule.yml file under the group_vars.

Running molecule test or molecule verify if the molecule create && molecule converge has already been run.

To have this test pass the role could be updated to include tasks like this.

---
- name: Backup file
  ansible.builtin.copy:
    src: "{{ backup_file_source_path }}"
    dest: "{{ backup_file_destination_path }}"
    mode: '0600'
    remote_src: yes

backup_file/tasks/verify.yml

We will also need to make sure that backup_file_source_path is provided same as the backup_file_destination_path mentioned above.

Observed behavior
molecule login -h molecule-ubi8-init-1 fails when using OpenShift pods as the molecule test infra

Expected behavior
We should be able to run the command above and log in to the instance

Description

For the oc_connection molecule demo, once molecule prepare is run, the user needs to run "source ~/.bashrc" to have oc recognized on the path. Jeff proposed 3 options for getting rid of this:

• include oc in the container image
• include oc in the dev file so that its downloaded and stored somewhere already in the path
• put together some shell script in the image that is executed (hopefully automatically on launch)

Description

As a user of ansible in devspaces I want it to be so! easy! i want a big old button like they have for the other dev spaces:

Right now we have the environment definition and sample project content in the same repo. This should be broken up into two repositories using the starter project feature of devfiles.

https://devfile.io/docs/2.2.0/defining-starter-projects

Description

In the devspace, git requires configuration of username and email for each new devspace and a personal access token is required every time you want to interact with git (commit, push, etc.)

Documentation

I've tried following these steps to resolve the issue without success: https://www.eclipse.org/che/docs/stable/administration-guide/configuring-oauth-2-for-github/

???

Description

As a responsible ansible developer, I want to have a pre-commit hook in place that prevents me from committing secrets while developing in the dev spaces

Documentation

Description

As a prospective user of ansible in dev spaces, I want it to be painfully clear to me how I could leverage this new technology. Include pointers towards lint docs, the molecule ocp situation, and perhaps a demo?

Status badge are typically used to show status and then provide more information when clicked on. I found it a bit confusing that the button at the top of the readme is how you actually launch the demo. Consider switching to another mechanism for launching the demo such as a different button, or at least call more attention to the one that exists currently