kwonoj / hunspell-dict-downloader Goto Github PK

Hi! first of all, thanks for this really cool package. I've been using it alongside electron-hunspell!

So, I just tested this on a Windows 10 system (using an electron program built with electron-winstaller), and I had an error when I tried to install a package (I tested with 'pt-br', if you need, I can test with others). The Error I got was:

Dictionary is installed, but failed to check integrity
at Object. (C:\ ... \createDownloader.js:79)

Looking at your code, at the method install, it seems that:
const isValid = await isInstalledDictionaryValid(dictionaryDirectory, langRegionCode);
is returning false.

As you can see from the code below (I adapted it a little to put here, but the idea is pretty much this), I first check to see if the language pack is installed, and if it isn't I try to install it before doing anything else.

dictDownloader.createDownloader(dictPath).then(manager => {
    let lang = 'pt-br'
    if (!manager.installedDictionaries.includes(lang)) { 
      // returns false, aka language package not installed
      return manager.installDictionary(langSet)
  }
}).then(() => {
  // use the language package installed for spell checking
}).catch(err => {
      console.log(err)
    })

I'm not sure if I'm doing something stupid, if there is a Windows dependency that I'm supposed to install or whether this is an actual bug. On a MacOs, at least, it worked perfectly (both installed versions and in development).
Any ideas?
Thanks again

The devDependency @types/jest was updated from 23.3.6 to 23.3.7.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/jest is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Hello, the version on NPM doesn't work for me.
However, your git master has been working fine.
Could you make a new release on NPM?

Thanks!

The devDependency npm-run-all was updated from 4.1.4 to 4.1.5.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

npm-run-all is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency @types/node was updated from 10.10.2 to 10.10.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/node is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency prettier was updated from 1.14.2 to 1.14.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

prettier is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency lint-staged was updated from 8.0.2 to 8.0.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

lint-staged is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency @types/node was updated from 10.12.6 to 10.12.7.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/node is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

import * as pacote from 'pacote';
import * as log from 'npmlog';

log.level = 'silly';

const test = async () => {
  console.log(await pacote.manifest('dictionary-en-us'))
  //1. do not re-extract if exists
  //2. do not attempt to download multiple times
  //3. extracted file integrity, busting logic

  const a = pacote.extract('dictionary-en-us', './temp', {
    integrity: 'sha512-AK8iDBvTHD0bxcEFEDUtofQ9w8Po7ZQCrrZo06ELw3UngJcnjUoEwvrkQfdeRBRcKD+QG9RU6SPYFYGGbuEQXQ==',
    preferOnline: false,
    cache: './cache',
    log: log
  })

  /*
  const b = pacote.extract('dictionary-en-us', './temp', {
    integrity: 'sha512-AK8iDBvTHD0bxcEFEDUtofQ9w8Po7ZQCrrZo06ELw3UngJcnjUoEwvrkQfdeRBRcKD+QG9RU6SPYFYGGbuEQXQ==',
    log: log
  })

  await Promise.all([a,b])*/
  await a;
}

test();

1. generate manifest for tar integrity / actual file md5, including metadata to download
2. test hash on different platform (linux, windows)

The devDependency conventional-changelog-cli was updated from 2.0.5 to 2.0.7.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

conventional-changelog-cli is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Instead of rely on single manifest by asking npm directly all times, it'd better to expand

1. accepts custom manifest directly (via json, or some other types) instead of having its own manifest
2. accepts custom installation logic other than using pacote

to allow customizability for source of dictionaries. Once this is done, default manifest should be extracted from package and each consumer should own their own manifest.

The dependency pify was updated from 4.0.0 to 4.0.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

pify is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

cross platform hash required.

The devDependency ts-jest was updated from 23.1.4 to 23.10.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ts-jest is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴