kunicmarko20 / jms-messenger-adapter Goto Github PK

View Code? Open in Web Editor NEW

9.0 2.0 8.0 38 KB

Use JMS Serializer with Symfony Messenger.

License: MIT License

PHP 97.85% Gherkin 1.21% Makefile 0.94%

symfony symfony-messenger jms-serializer

jms-messenger-adapter's Introduction

JMS Messenger Adapter

Use JMS Serializer with Symfony Messenger.

Installation

Add dependency with Composer:

composer require kunicmarko/jms-messenger-adapter

Symfony

Enable the bundle for all environments:

// bundles.php
return [
    //...
    KunicMarko\JMSMessengerAdapter\Bridge\Symfony\JMSMessengerAdapterBundle::class => ['all' => true],
];

Configuration

#config/packages/jms_messenger.yaml
jms_messenger:
    format: json # xml, json
    serializer_id: messenger.transport.jms_serializer

Serialized id should be configured in the messenger config, in case you did not get the recipe, just add:

#config/packages/jms_messenger.yaml
framework:
  messenger:
    enabled: true
    serializer:
      default_serializer: messenger.transport.jms_serializer

Stamps

This library provides additional stamps that will use JMS Deserialization/Serialization Context for serializing/deserializing messages.

use JMS\Serializer\SerializationContext;
use KunicMarko\JMSMessengerAdapter\Stamp\SerializationContextStamp;

$context = SerializationContext::create();
$context->setGroups(['foo']);
        
$messageBus->dispatch(new Message(), [new SerializationContextStamp($context)]);

jms-messenger-adapter's People

Contributors

Stargazers

Watchers

Forkers

chq81 ruudk hanspeterording maryo nhello petrepatrasc vshtanze

jms-messenger-adapter's Issues

Mention Stamps in Readme

https://github.com/kunicmarko20/jms-messenger-adapter/tree/master/src/Stamp

Fix e2e build

Travis started failing for no reason, would be great to fix it, because there is no coverage if this actually works besides unit tests.

Context::$initialized should always be false

when serializing JMS\Serializer\Context, the Context::$initialized property should be omitted or overridden to false

jms-messenger-adapter/src/Resources/config/serializer/JMS.Serializer.Context.xml

Line 5 in 3bcf81b

ATM it is not, which causes errors when requeuing a message:


  [JMS\Serializer\Exception\LogicException]
  This context was already initialized, and cannot be re-used.


Exception trace:
 () at /code/vendor/jms/serializer/src/Context.php:65
 JMS\Serializer\Context->initialize() at /code/vendor/jms/serializer/src/Serializer.php:236
 JMS\Serializer\Serializer->visit() at /code/vendor/jms/serializer/src/Serializer.php:178
 JMS\Serializer\Serializer->deserialize() at /code/src/Messenger/Serializer.php:49
 App\Messenger\Serializer->decode() at /code/vendor/sroze/messenger-enqueue-transport/QueueInteropTransport.php:85
 Enqueue\MessengerAdapter\QueueInteropTransport->get() at /code/vendor/symfony/messenger/Worker.php:88
 Symfony\Component\Messenger\Worker->run() at /code/vendor/symfony/messenger/Worker/StopWhenRestartSignalIsReceived.php:54
 Symfony\Component\Messenger\Worker\StopWhenRestartSignalIsReceived->run() at /code/vendor/symfony/messenger/Command/ConsumeMessagesCommand.php:228
 Symfony\Component\Messenger\Command\ConsumeMessagesCommand->execute() at /code/vendor/symfony/console/Command/Command.php:255
 Symfony\Component\Console\Command\Command->run() at /code/vendor/symfony/console/Application.php:939
 Symfony\Component\Console\Application->doRunCommand() at /code/vendor/symfony/framework-bundle/Console/Application.php:87
 Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() at /code/vendor/symfony/console/Application.php:273
 Symfony\Component\Console\Application->doRun() at /code/vendor/symfony/framework-bundle/Console/Application.php:73
 Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at /code/vendor/symfony/console/Application.php:149
 Symfony\Component\Console\Application->run() at /code/bin/console:38

seems like requeuing serializes the unserialized and "used" stamps of the original message.

Serializer - exclude NonSendableStampInterface

Serializer::encode should exclude all stamps implementing NonSendableStampInterface

just like in symfony/messenger default serializer:
https://github.com/symfony/messenger/blob/c7c5be1caf277150c84b36b6a430654717bd0956/Transport/Serialization/Serializer.php#L100

$envelope = $envelope->withoutStampsOfType(NonSendableStampInterface::class);

Serializer configuration issue has changed

As part of the following PR: symfony/symfony#30628

Encoded envelope should have at least a "body" and some "headers"

Hi,

I copy/paste the code provided in the documentation. When I receive the message with my consumer I get the error

[KunicMarko\JMSMessengerAdapter\Exception\ArgumentMissing]
Encoded envelope should have at least a "body" and some "headers".

Exception trace:
at /var/application/vendor/kunicmarko/jms-messenger-adapter/src/Exception/ArgumentMissing.php:11
KunicMarko\JMSMessengerAdapter\Exception\ArgumentMissing::envelopeBodyAndHeaders() at /var/application/vendor/kunicmarko/jms-messenger-adapter/src/Serializer.php:32
KunicMarko\JMSMessengerAdapter\Serializer->decode() at /var/application/vendor/symfony/messenger/Transport/AmqpExt/AmqpReceiver.php:66
Symfony\Component\Messenger\Transport\AmqpExt\AmqpReceiver->getEnvelope() at /var/application/vendor/symfony/messenger/Transport/AmqpExt/AmqpReceiver.php:45
Symfony\Component\Messenger\Transport\AmqpExt\AmqpReceiver->get() at /var/application/vendor/symfony/messenger/Worker.php:78
Symfony\Component\Messenger\Worker->run() at /var/application/vendor/symfony/messenger/Command/ConsumeMessagesCommand.php:186
Symfony\Component\Messenger\Command\ConsumeMessagesCommand->execute() at /var/application/vendor/symfony/console/Command/Command.php:255
Symfony\Component\Console\Command\Command->run() at /var/application/vendor/symfony/console/Application.php:930
Symfony\Component\Console\Application->doRunCommand() at /var/application/vendor/symfony/framework-bundle/Console/Application.php:97
Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() at /var/application/vendor/symfony/console/Application.php:264
Symfony\Component\Console\Application->doRun() at /var/application/vendor/symfony/framework-bundle/Console/Application.php:83
Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at /var/application/vendor/symfony/console/Application.php:140
Symfony\Component\Console\Application->run() at /var/application/bin/console:42

Symfony 5
Messenger 5.0

Include missing stamps

Hi,
Symfony 4.3 provides a lot of different stamps.
Unfortunately not all of them can be serialized as they are missing from the serializer configuration.
These include:

DelayStamp
RedeliveryStamp
HandledStamp
SentToFailureTransportStamp
TransportMessageIdStamp

Can you add them please?
Thanks a lot for your work!

Make it conflict with 4.3

There are probably some issues between 4.2 and 4.3. Lib should conflict with 4.3 until addressed.