kumuluz / kumuluzee-graphql Goto Github PK

Hi, I've done a test with CDI and bean-discovery-mode set to annotated. In that context, standard Java classes (non-CDI beans) annotated with @GraphQLClass are treated as non-contextual CDI beans (based on Unmanaged CDI bean) in GraphQLServlet and implicitly benefit from some CDI injection. Is it a an expected behavior?
Furthermore, CDI beans are also instanciated as non-contextual. And according to that article, it is said that "Unmanaged.UnmanagedInstances created by this class are not suitable for sharing between threads".
My proposal would be to instanciate non CDI-beans using Java new() and to get references on CDI beans using the BeanManager. What do you think?

I think there is a bug in GraphQLServlet when more than 1 GraphApplicationClass has been discovered:

• A warning log message is produced on line 96,
• But the process flow is not interrupted and applicationClass is not initialized,
• this can result in a NullPointerException on line 101.

Correct me if I'm wrong.