kulbakin / laravel-browscap Goto Github PK

Support for bug fixes for Laravel 5.8 ended on August 26, 2019. Security issues are still being maintained until February 26, 2020.

I got the following exception while trying to use the fascade:

"Call to undefined method Illuminate\Log\Writer::driver()"

Changing "$app->make('log')->driver()" to "$app->make('log')" in BrowscapServiceProvider.php seems to solve the problem.

On the package page https://packagist.org/packages/propa/laravel-browscap it's still 1.1.0 version, can you please update it there?

The Browscap 4.0 is almost ready we/you/me should prepare service provider to match it.

When running composer require propa/laravel-browscap

I get the following error: Any help appreciated.

> @php artisan package:discover --ansi

   TypeError 

  BrowscapPHP\Command\CheckUpdateCommand::__construct(): Argument #1 ($defaultCacheFolder) must be of type string, null given, called in /var/www/html/vendor/propa/laravel-browscap/src/Console/CheckUpdateCom
mand.php on line 23

  at vendor/browscap/browscap-php/src/Command/CheckUpdateCommand.php:30
     26▕      * @var string
     27▕      */
     28▕     private $defaultCacheFolder;
     29▕ 
  ➜  30▕     public function __construct(string $defaultCacheFolder)
     31▕     {
     32▕         $this->defaultCacheFolder = $defaultCacheFolder;
     33▕ 
     34▕         parent::__construct();

      +1 vendor frames
  2   [internal]:0
      Propa\BrowscapPHP\Console\CheckUpdateCommand::__construct()

      +12 vendor frames
  15  artisan:37
      Illuminate\Foundation\Console\Kernel::handle()
Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 1
ERROR: 1

Did you have any success on using laravel-browscap 2.0.8 on a php 8 project? For me, browscap 4.3 can not be installed on php 8 and I have to manually override the version in my installation like "browscap/browscap-php": "5.0.0 as 4.3.0", in my composer.json

Hi based on Laravel 5 uses PSR-2

PSR-2 Extends PSR-1 in which php ini_set() is in Side Effects

I think ini_set should be removed from command and be set by End user if necessary.

When running artisan command we can always do:

php -d memory_limit=512M artisan browscap:update

When installing the package it gives information that it has a vulnerability